Repository navigation
[DECO-28500] Fix config-remote-sync writing run_as: {} on a principal kind switch - #7493
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=4 unreleased=0 coverage=0 failing=0
TestAccept/bundle/config-remote-sync/job_run_as/DMS=: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) TestAccept/bundle/config-remote-sync/job_run_as/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) TestAccept/bundle/config-remote-sync/job_run_as_sources/DMS=: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) TestAccept/bundle/config-remote-sync/job_run_as_sources/DMS=true: branch ✅ | main (46546d1) ❌ | latest (v1.26.0) ❌main (46546d1): latest (v1.26.0): same output as main (46546d1) |
Collaborator
✅ Integration test reportCommit: 4e889ab
Top 4 slowest tests (at least 2 minutes):
|
petrapostelnicu-db
force-pushed
the
deco-28500-run-as-kind-switch
branch
from
November 12, 2026 15:30
30d51c4 to
c2002f7
Compare
petrapostelnicu-db
marked this pull request as ready for review
November 12, 2026 15:31
ilyakuz-db
approved these changes
Nov 12, 2026
petrapostelnicu-db
force-pushed
the
deco-28500-run-as-kind-switch
branch
2 times, most recently
from
November 13, 2026 12:09
8fc936c to
ecaf0b7
Compare
The plan skips a job's run_as keys that the config lacks as backend
defaults. When the remote switches principal kind, the new key is the
edit itself, so config-remote-sync removed the old key and dropped the
new one, leaving run_as: {}. Let skipped run_as keys through.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
config-remote-sync is a hidden command used only by DABs in the workspace; changes to it do not get release notes. Co-authored-by: Isaac <no-reply@databricks.com>
petrapostelnicu-db
force-pushed
the
deco-28500-run-as-kind-switch
branch
from
November 13, 2026 12:17
043bb5d to
4e889ab
Compare
Collaborator
❌ Integration test reportCommit: e3aeacc
61 interesting tests: 37 FAIL, 13 flaky, 11 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
run_askeys that the plan skipped as backend defaults through to config-remote-sync (bundle/configsync/runas.go).Why
config-remote-syncafter a run-as change.run_askind (e.g.user_name→service_principal_name) removed the old key but dropped the new one: the plan marks arun_askey the config lacks as a backend default. The YAML ended up withrun_as: {}, and the next sync and plan reported no changes.run_as.Tests
config-remote-sync/job_run_as: user → user, user → creator, user → service principal.config-remote-sync/job_run_as_sources: bundle-levelrun_as, unchanged inherited job,${var}reference, target override, group.keepSkippedRunAsChange.This pull request and its description were written by Isaac.