Repository navigation
Apply resource lifecycle metadata in config-remote-sync change detection - #7645
Open
ilyakuz-db wants to merge 4 commits into
Open
ilyakuz-db wants to merge 4 commits into
ilyakuz-db wants to merge 4 commits into
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 2d69c06
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
config-remote-syncnow applies the direct engine's lifecycle metadata to every change, whatever action the plan gave it (bundle/configsync/lifecycle.go). A remote value is never written back when it falls underignore_remote_changes(output-only, input-only, backend-managed), or when it's a backend default the config doesn't set.node_type_idin a task added in the UI may be the user's pick, so it's kept.run_askeys are still synced, so a principal kind switch keeps working ([DECO-28500] Fix config-remote-sync writingrun_as: {}on a principal kind switch #7493).bundle/directtodresources.ResourceLifecycleConfig.IsBackendDefaultso the plan and config sync share it. The plan's behavior doesn't change.Why
Config sync only dropped changes the plan marked as skipped. Metadata-covered fields still reached the YAML whenever the plan reported an update, or reported the object that contains them:
etagisoutput_only, butOverrideChangeDescpromotes etag drift to an update for deploy, so the etag ended up in the YAML.trigger.table_update.condition), or when the whole object was missing remotely (a serving endpoint'stelemetry_config.table_names).aws_attributesunder a for-each task's cluster).formatonce the config dropped it, orspark.sql.ansi.enabledinside a pipelineconfigurationmap added remotely.Tests
diff_test.gocovering each case above, plus therun_asswitch and a backend default with a non-default value. It fails without the fix.go test ./bundle/..., theconfig-remote-syncacceptance tests and golangci-lint pass locally.This pull request and its description were written by Isaac.