Skip to content

Add eng-deco-dabs-ws team as configsync approvers - #7459

Merged
ilyakuz-db merged 3 commits into
mainfrom
configsync-codeowners
Nov 11, 2026
Merged

ilyakuz-db merged 3 commits into
mainfrom
configsync-codeowners

Conversation

@ilyakuz-db

@ilyakuz-db ilyakuz-db commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Adds the new @databricks/eng-deco-dabs-ws team (DABs in the Workspace) as CODEOWNERS for /bundle/configsync/ and the config-remote-sync acceptance tests, in addition to the existing bundle owners.

Why

configsync powers bundle config-remote-sync, which the DABs in the Workspace frontend relies on. Our team builds and maintains much of it, so we should be able to approve changes there.

Tests

tools/validate_codeowners.py passes.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@ilyakuz-db
ilyakuz-db requested a review from a team as a code owner November 11, 2026 11:08
Comment thread .github/CODEOWNERS Outdated

# Bundles
/bundle/ @databricks/eng-deco-cli @databricks/eng-deco-dabs
/bundle/configsync/ @databricks/eng-deco-cli @databricks/eng-deco-dabs @andersrexdb @ilyakuz-db @pavloKozlov

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a team?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also move that team under @databricks/eng-dev-ecosystem so it inherits write access (required for a team in CODEOWNERS)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks! Also updated boundaries to include configsync acceptance tests

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 5440f00

Run: 43020776243

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 5:51
✅​ aws-windows-latest-4core-16gb 273 13 3:44
✅​ azure linux-2core-8gb 270 15 5:44
✅​ azure-windows-latest-4core-16gb 272 13 3:46
✅​ gcp linux-2core-8gb 271 15 5:51
✅​ gcp-windows-latest-4core-16gb 273 13 4:27
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:25 gcp-windows-latest-4core-16gb TestAccept
3:58 aws linux-2core-8gb TestAccept
3:55 gcp linux-2core-8gb TestAccept
3:53 azure linux-2core-8gb TestAccept
3:42 aws-windows-latest-4core-16gb TestAccept
3:40 azure-windows-latest-4core-16gb TestAccept

Co-authored-by: Isaac <no-reply@databricks.com>
@ilyakuz-db ilyakuz-db changed the title Add DABs in the Workspace frontend owners as configsync approvers Add eng-deco-dabs-ws team as configsync approvers Nov 11, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
@ilyakuz-db
ilyakuz-db added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 7ac220c Nov 11, 2026
28 checks passed
@ilyakuz-db
ilyakuz-db deleted the configsync-codeowners branch November 11, 2026 13:08
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: 7ac220c

Run: 43026606008

Env ❌​FAIL 🔄​flaky ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 4 6 1521 1274 286:00
❌​ aws-windows-latest-4core-16gb 4 4 1442 1301 295:10
❌​ azure linux-2core-8gb 3 9 1499 1282 274:04
❌​ azure-windows-latest-4core-16gb 4 1426 1309 301:53
❌​ gcp linux-2core-8gb 22 1496 1280 293:29
❌​ gcp-windows-latest-4core-16gb 7 8 1422 1307 347:12
50 interesting tests: 25 FAIL, 25 flaky
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
❌​ TestAccept ❌​F ❌​F 🔄​f ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/deploy/immutable/can-manage ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/deploy/immutable/can-manage/DMS= ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/deployment-metadata-change ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/deployment-metadata-change/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/stale-local-state ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/stale-local-state/DMS= ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/successful-recreate ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/dms/successful-recreate/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/alerts/basic ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/alerts/basic/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/alerts/basic/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/resources/apps/lifecycle-started ✅​p ✅​p ✅​p ✅​p ❌​F 🔄​f
🔄​ TestAccept/bundle/resources/apps/lifecycle-started-toggle ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS= ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/apps/lifecycle-started/DMS= ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
❌​ TestAccept/bundle/resources/apps/lifecycle-started/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
🔄​ TestAccept/bundle/resources/cluster_policies/policy_family_overrides ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/cluster_policies/policy_family_overrides/DMS=true ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/clusters/lifecycle-started ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/clusters/lifecycle-started/DMS= ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/features/lifecycle ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/features/lifecycle/DMS= ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestAccept/bundle/resources/materialization_sets/batch 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/materialization_sets/batch/DMS= 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/model_serving_endpoints/basic ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/model_serving_endpoints/basic/DMS=true ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/pipelines/allow-duplicate-names 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/pipelines/allow-duplicate-names/DMS=true 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_databases/replace_existing 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=true 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_databases/update ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_databases/update/DMS=true ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_endpoints/recreate ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/resources/postgres_endpoints/recreate/DMS=true ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/resources/postgres_roles/recreate ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/postgres_roles/recreate/DMS= ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/postgres_roles/update ✅​p ✅​p ✅​p ✅​p ✅​p ❌​F
❌​ TestAccept/bundle/resources/postgres_roles/update/DMS= ✅​p ✅​p ✅​p ✅​p ✅​p ❌​F
❌​ TestAccept/bundle/resources/postgres_roles/update/DMS=true ✅​p ✅​p ✅​p ✅​p ✅​p ❌​F
❌​ TestAccept/bundle/resources/postgres_snapshot_schedules/basic ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/postgres_snapshot_schedules/basic/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/postgres_synced_tables/recreate ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/resources/postgres_synced_tables/recreate/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
🔄​ TestAccept/bundle/resources/synced_database_tables/basic ✅​p ✅​p 🔄​f ✅​p 🙈​s 🙈​s
🔄​ TestAccept/bundle/resources/synced_database_tables/basic/DMS=true ✅​p ✅​p 🔄​f ✅​p
❌​ TestAccept/bundle/run_as/job_default ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
❌​ TestAccept/bundle/run_as/job_default/DMS=true ✅​p ✅​p ✅​p ✅​p ❌​F ✅​p
🔄​ TestAccept/bundle/select/basic ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/select/basic/DMS=/READPLAN= ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
Top 50 slowest tests (at least 2 minutes):
duration env testname
20:27 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
14:57 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=true
12:20 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
11:34 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
11:24 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
11:13 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
11:09 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
10:20 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:09 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:08 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
10:02 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/data_security_mode/DMS=true
9:54 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
9:31 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
9:16 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
9:03 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
9:01 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=true
9:00 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:54 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
8:47 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:46 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:38 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:29 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:26 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
8:22 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:21 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
8:15 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1
8:11 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
8:07 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:04 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
7:53 azure linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=
7:42 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:40 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:38 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
7:30 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
7:28 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
7:12 azure linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
7:06 gcp-windows-latest-4core-16gb TestAccept/bundle/quiet-levels/DMS=true
7:06 aws linux-2core-8gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
7:04 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:03 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:01 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
6:58 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
6:50 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/inline_config/DMS=
6:48 gcp linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=
6:43 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=yes/DMS=/NBOOK=yes/PY=yes/READPLAN=
6:40 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
6:39 azure-windows-latest-4core-16gb TestAccept/bundle/quiet-levels/DMS=true
6:36 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
6:35 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=
6:35 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true

tedjt pushed a commit to tedjt/cli that referenced this pull request Nov 12, 2026
## Changes
`testmask` now ignores `.github/CODEOWNERS`. A PR that only touches that
file gets no test targets, so the unit test matrix and integration tests
are skipped.

## Why
CODEOWNERS-only PRs (e.g. databricks#7459) ran the full test matrix and
integration tests, because unmatched files fall back to `test`.
CODEOWNERS is still validated by `task checks` in the `lint` job, and
all required checks still report on the skip path.

## Tests
Added unit cases. Ran testmask against databricks#7459's commits, and it now
returns `[]`.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants