Repository navigation
Add eng-deco-dabs-ws team as configsync approvers - #7459
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Nov 11, 2026
|
|
||
| # Bundles | ||
| /bundle/ @databricks/eng-deco-cli @databricks/eng-deco-dabs | ||
| /bundle/configsync/ @databricks/eng-deco-cli @databricks/eng-deco-dabs @andersrexdb @ilyakuz-db @pavloKozlov |
Member
There was a problem hiding this comment.
please also move that team under @databricks/eng-dev-ecosystem so it inherits write access (required for a team in CODEOWNERS)
Contributor
Author
There was a problem hiding this comment.
Done, thanks! Also updated boundaries to include configsync acceptance tests
Collaborator
✅ Integration test reportCommit: 5440f00
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Nov 11, 2026
Collaborator
❌ Integration test reportCommit: 7ac220c
50 interesting tests: 25 FAIL, 25 flaky
Top 50 slowest tests (at least 2 minutes):
|
tedjt
pushed a commit
to tedjt/cli
that referenced
this pull request
Nov 12, 2026
## Changes `testmask` now ignores `.github/CODEOWNERS`. A PR that only touches that file gets no test targets, so the unit test matrix and integration tests are skipped. ## Why CODEOWNERS-only PRs (e.g. databricks#7459) ran the full test matrix and integration tests, because unmatched files fall back to `test`. CODEOWNERS is still validated by `task checks` in the `lint` job, and all required checks still report on the skip path. ## Tests Added unit cases. Ran testmask against databricks#7459's commits, and it now returns `[]`. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds the new
@databricks/eng-deco-dabs-wsteam (DABs in the Workspace) as CODEOWNERS for/bundle/configsync/and theconfig-remote-syncacceptance tests, in addition to the existing bundle owners.Why
configsyncpowersbundle config-remote-sync, which the DABs in the Workspace frontend relies on. Our team builds and maintains much of it, so we should be able to approve changes there.Tests
tools/validate_codeowners.pypasses.This pull request and its description were written by Isaac.