Skip to content

Skip tests in testmask for CODEOWNERS-only changes - #7483

Merged
ilyakuz-db merged 1 commit into
mainfrom
testmask-skip-codeowners
Nov 11, 2026
Merged

ilyakuz-db merged 1 commit into
mainfrom
testmask-skip-codeowners

Conversation

@ilyakuz-db

Copy link
Copy Markdown
Contributor

Changes

testmask now ignores .github/CODEOWNERS. A PR that only touches that file gets no test targets, so the unit test matrix and integration tests are skipped.

Why

CODEOWNERS-only PRs (e.g. #7459) ran the full test matrix and integration tests, because unmatched files fall back to test. CODEOWNERS is still validated by task checks in the lint job, and all required checks still report on the skip path.

Tests

Added unit cases. Ran testmask against #7459's commits, and it now returns [].

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>

@janniklasrose janniklasrose left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea! lots of things to add here (READMEs, .agents/* [requires wildcard matching], etc) as follow-up

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 5376618

Run: 43039894327

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 8:20
✅​ aws-windows-latest-4core-16gb 273 13 18:54
✅​ azure linux-2core-8gb 270 15 9:56
✅​ azure-windows-latest-4core-16gb 272 13 18:37
✅​ gcp linux-2core-8gb 271 15 9:16
🔄​ gcp-windows-latest-4core-16gb 10 263 13 30:11
10 interesting tests: 10 flaky
Test Name gcp-windows-latest-4core-16gb
🔄​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_local 🔄​f
🔄​ TestFsCpDirToDirFileNotOverwritten/dbfs_to_uc-volumes 🔄​f
🔄​ TestFsCpDirToDirFileNotOverwritten/uc-volumes_to_dbfs 🔄​f
🔄​ TestFsCpDirToDirWithOverwriteFlag 🔄​f
🔄​ TestFsCpDirToDirWithOverwriteFlag/dbfs_to_dbfs 🔄​f
🔄​ TestFsCpFileToDirFileNotOverwritten/dbfs_to_dbfs 🔄​f
🔄​ TestFsCpFileToDirFileNotOverwritten/dbfs_to_local 🔄​f
🔄​ TestFsCpFileToDirFileNotOverwritten/uc-volumes_to_dbfs 🔄​f
🔄​ TestFsCpFileToFileFileNotOverwritten 🔄​f
🔄​ TestFsCpFileToFileFileNotOverwritten/dbfs_to_dbfs 🔄​f
Top 36 slowest tests (at least 2 minutes):
duration env testname
4:45 gcp-windows-latest-4core-16gb TestAccept
4:44 gcp-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/dbfs_to_dbfs
4:38 aws-windows-latest-4core-16gb TestAccept
4:04 aws linux-2core-8gb TestAccept
3:57 azure linux-2core-8gb TestAccept
3:56 azure-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/dbfs_to_dbfs
3:55 gcp linux-2core-8gb TestAccept
3:42 aws-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/dbfs_to_dbfs
3:39 gcp-windows-latest-4core-16gb TestFilerReadWrite/dbfs
3:33 azure-windows-latest-4core-16gb TestAccept
3:12 aws-windows-latest-4core-16gb TestFsCpDir/dbfs_to_dbfs
3:05 gcp-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/dbfs_to_uc-volumes
3:04 azure-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/dbfs_to_dbfs
2:55 aws-windows-latest-4core-16gb TestFsCpFileToDirFileNotOverwritten/dbfs_to_dbfs
2:55 gcp linux-2core-8gb TestFilerRecursiveDelete/dbfs
2:54 azure-windows-latest-4core-16gb TestFilerReadWrite/dbfs
2:42 azure-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/dbfs_to_local
2:34 aws-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/uc-volumes_to_dbfs
2:32 azure-windows-latest-4core-16gb TestFsCpFileToDirFileNotOverwritten/dbfs_to_dbfs
2:31 gcp-windows-latest-4core-16gb TestFsCpFileToFileWithOverwriteFlag/dbfs_to_dbfs
2:24 gcp-windows-latest-4core-16gb TestFsCpFileToFileFileNotOverwritten/dbfs_to_uc-volumes
2:23 aws-windows-latest-4core-16gb TestFsCpFileToFileFileNotOverwritten/dbfs_to_dbfs
2:22 aws-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/dbfs_to_uc-volumes
2:19 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/dbfs
2:18 azure-windows-latest-4core-16gb TestFsCpFileToFileWithOverwriteFlag/dbfs_to_dbfs
2:18 gcp-windows-latest-4core-16gb TestFsCpDir/dbfs_to_dbfs
2:17 gcp-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/local_to_dbfs
2:16 gcp-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/local_to_dbfs
2:14 aws-windows-latest-4core-16gb TestFilerReadDir/dbfs
2:09 gcp-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/uc-volumes_to_dbfs
2:07 aws-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/dbfs_to_dbfs
2:05 gcp-windows-latest-4core-16gb TestFsCpFileToFileFileNotOverwritten/dbfs_to_local
2:04 aws-windows-latest-4core-16gb TestFsCpDir/uc-volumes_to_dbfs
2:03 aws-windows-latest-4core-16gb TestFsCpDirToDirFileNotOverwritten/dbfs_to_uc-volumes
2:02 azure-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/local_to_dbfs
2:00 gcp-windows-latest-4core-16gb TestFsCpSourceIsDirectoryButTargetIsFile/dbfs_to_dbfs

@ilyakuz-db
ilyakuz-db marked this pull request as ready for review November 11, 2026 15:23
@ilyakuz-db
ilyakuz-db requested a review from a team as a code owner November 11, 2026 15:23
@ilyakuz-db
ilyakuz-db requested a review from anton-107 November 11, 2026 15:23
@ilyakuz-db
ilyakuz-db added this pull request to the merge queue Nov 11, 2026
@ilyakuz-db

Copy link
Copy Markdown
Contributor Author

I'll do as a follow-up

Merged via the queue into main with commit 1d69dfe Nov 11, 2026
28 checks passed
@ilyakuz-db
ilyakuz-db deleted the testmask-skip-codeowners branch November 11, 2026 15:34
tedjt pushed a commit to tedjt/cli that referenced this pull request Nov 12, 2026
…7484)

## Changes
Follow-up to databricks#7483. `testmask` now ignores agent config (`.agents/`,
`.claude/`, `.cursor/`, `AGENTS.md`), root docs (`README.md`,
`CHANGELOG.md`, `SECURITY.md`), GitHub issue/PR templates, and
`.nextchanges` fragments. Ignored entries support `path.Match` globs and
a trailing `/**` for directories.

## Why
PRs touching only these files (e.g. databricks#7464, databricks#7448, databricks#7344) still ran the
full test matrix. Nested READMEs are left out since many are acceptance
outputs or embedded templates.

## Tests
Added unit cases, and testmask returns `[]` for the PRs above.

This pull request and its description were written by Isaac.

---------

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants