Repository navigation
Skip tests in testmask for CODEOWNERS-only changes - #7483
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Nov 11, 2026
janniklasrose
left a comment
Member
There was a problem hiding this comment.
great idea! lots of things to add here (READMEs, .agents/* [requires wildcard matching], etc) as follow-up
Collaborator
✅ Integration test reportCommit: 5376618
10 interesting tests: 10 flaky
Top 36 slowest tests (at least 2 minutes):
|
Contributor
Author
|
I'll do as a follow-up |
tedjt
pushed a commit
to tedjt/cli
that referenced
this pull request
Nov 12, 2026
…7484) ## Changes Follow-up to databricks#7483. `testmask` now ignores agent config (`.agents/`, `.claude/`, `.cursor/`, `AGENTS.md`), root docs (`README.md`, `CHANGELOG.md`, `SECURITY.md`), GitHub issue/PR templates, and `.nextchanges` fragments. Ignored entries support `path.Match` globs and a trailing `/**` for directories. ## Why PRs touching only these files (e.g. databricks#7464, databricks#7448, databricks#7344) still ran the full test matrix. Nested READMEs are left out since many are acceptance outputs or embedded templates. ## Tests Added unit cases, and testmask returns `[]` for the PRs above. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
testmasknow ignores.github/CODEOWNERS. A PR that only touches that file gets no test targets, so the unit test matrix and integration tests are skipped.Why
CODEOWNERS-only PRs (e.g. #7459) ran the full test matrix and integration tests, because unmatched files fall back to
test. CODEOWNERS is still validated bytask checksin thelintjob, and all required checks still report on the skip path.Tests
Added unit cases. Ran testmask against #7459's commits, and it now returns
[].This pull request and its description were written by Isaac.