Repository navigation
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
emupton
force-pushed
the
feat/application-token/02-revoke-expiry
branch
from
November 17, 2026 11:33
fff09dc to
9f273f9
Compare
emupton
marked this pull request as ready for review
November 17, 2026 13:29
bthuillier
requested changes
Nov 18, 2026
bthuillier
left a comment
Contributor
There was a problem hiding this comment.
Contract matches console-plus 👍. Please drop --expires-at from token create admin: Console ignores it for admin tokens, so it gives a false sense of expiry. Keep it on create application only.
Nit: token revoke only works for application tokens, worth saying in the help.
…-only Review follow-ups on the revoke/--expires-at PR: - Console ignores expiresAt when creating admin tokens, so exposing --expires-at on `token create admin` gave a false sense of expiry. Remove the flag; keep it on `token create application`, where expiry is honoured. CreateAdminToken no longer sends expiresAt. - `token revoke` only works for application tokens (other kinds can only be deleted); say so in the command help. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Both addressed in
Verified end-to-end against a local Console (admin create still works without the flag; application |
bthuillier
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Console is introducing the ApplicationToken kind, scoped to a self-serve Application, closing a vulnerability where an ApplicationInstance token (e.g. a dev environment's CI token) could modify ApplicationGroups and grant itself production access. Alongside the new kind, Console adds token revocation and token expiry; this slice brings both to the CLI so compromised or stale tokens can be neutralized without deleting their audit trail.
What this PR does
conduktor token revoke <token-uuid>calling the newPOST /api/token/v1/{token-uuid}/revoke. Unliketoken delete, revocation is terminal: the token stays listed with a Revoked status.--expires-at(RFC3339) ontoken create adminandtoken create application. Validated client-side;expiresAtis only sent when the flag is set, so creating tokens against older Consoles keeps working and absent still means "never expires".Tokenstruct gainsExpiresAtandStatus(omitempty — older servers won't send them);token list applicationprints them when present.Milestone: full Application-token lifecycle (mint, list, expire, revoke) from ctl — against a mock; live verification once the Console backend merges.
How to verify
Stack: PR 2/4, on top of #156.
🤖 Generated with Claude Code