Skip to content

[app-token 3/4] docs and help text for Application tokens - #158

Merged
emupton merged 1 commit into
feat/application-token/02-revoke-expiryfrom
feat/application-token/03-docs
Nov 18, 2026
Merged

emupton merged 1 commit into
feat/application-token/02-revoke-expiryfrom
feat/application-token/03-docs

Conversation

@emupton

@emupton emupton commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Why

Console is introducing the ApplicationToken kind, scoped to a self-serve Application, closing a vulnerability where an ApplicationInstance token (e.g. a dev environment's CI token) could modify ApplicationGroups and grant itself production access. PRs 1-2 of this stack added the commands; the docs and help text still described only Admin and Application Instance tokens.

What this PR does

  • README: the token-kinds sentence now names the three kinds (Admin, Application — scoped to a self-serve Application — and Application Instance) and the example no longer implies CDK_API_KEY must be an admin token.
  • docs/env-var-config.md: same for the CDK_API_KEY entry.
  • conduktor token Short help and the root command's Long help mention Application tokens.
  • Fixes a pre-existing help-text bug: token create admin said you can authenticate with CDK_USER/CDK_PASSWORD "instead of CDK_TOKEN" — the variable the CLI actually reads is CDK_API_KEY.

Milestone: docs match reality.

How to verify

./conduktor token --help
./conduktor token create admin --help
grep -rn CDK_TOKEN .   # no hits

Stack: PR 3/4, on top of #157.

🤖 Generated with Claude Code

@emupton
emupton added this pull request to stack #162 November 12, 2026 10:46
@emupton
emupton force-pushed the feat/application-token/03-docs branch from a66e40b to 1e016ec Compare November 17, 2026 11:33
@emupton
emupton marked this pull request as ready for review November 17, 2026 13:29
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@emupton
emupton force-pushed the feat/application-token/03-docs branch from 1e016ec to 7adb5fb Compare November 18, 2026 10:31
@emupton
emupton merged commit 97ef581 into main Nov 18, 2026
7 checks passed
@emupton
emupton deleted the feat/application-token/03-docs branch November 18, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants