Enable silent stream test for WebAssembly - #493
Merged
Merged
Conversation
anutosh491
force-pushed
the
fix/wasm-tests
branch
from
September 23, 2026 06:11
25d9e94 to
794e8e3
Compare
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 18 18
Lines 1204 1204
Branches 113 113
=======================================
Hits 877 877
Misses 327 327 🚀 New features to boost your workflow:
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
I think this can be merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test previously failed while parsing
<iostream>because its interpreter did not receive:These arguments are already used by the JupyterLite WASM kernelspec. Without them, libc++ cannot find
xlocale.h.Fixes # (issue)
Type of change
Please tick all options which are relevant.