Skip to content

Fix clang-tidy dependency setup - #494

Merged
JohanMabille merged 2 commits into
compiler-research:mainfrom
anutosh491:fix/clang-tidy-ci
Sep 23, 2026
Merged

JohanMabille merged 2 commits into
compiler-research:mainfrom
anutosh491:fix/clang-tidy-ci

Conversation

@anutosh491

@anutosh491 anutosh491 commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Description

As seen in the last 2 prs #493 #492 this job is failing

The clang-tidy job has been failing before CMake or clang-tidy runs because ZedThree/clang-tidy-review@v0.23.1 attempts to install additional APT packages inside its Ubuntu 25.10 container. That installation exits with status 100.

This updates and simplifies the clang-tidy environment setup:

  • Remove the unnecessary apt_packages installation.
  • Update Micromamba from 1.5.10-0 to 2.8.1-0.
  • Verify the downloaded Micromamba binary using its SHA-256 checksum.
  • Use micromamba run instead of installing shell hooks and activating the environment.
  • Use the Clang 21 compiler provided by environment-dev.yml, matching the clang-tidy 21 toolchain.
  • Remove unused host-side Python and LLVM setup.
  • Remove the preliminary ignored CMake failure and redundant build cleanup.
  • Avoid host/container path assumptions by using relative paths.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@vgvassilev

Copy link
Copy Markdown
Contributor

You can take a look how this was done in clad -- we can port the changes here too, I believe.

@anutosh491

anutosh491 commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

You can take a look how this was done in clad -- we can port the changes here too, I believe.

Ahh okay I can move to how clad does it later. For now my goal is to just fix some issues/ci on xeus-cpp for my talk next week. These changes were some obvious improvements I could see (like moving micromamba from 1.5 to 2.8 etc & also the clang-tidy job was failing anyways). Hopefully this should be fine for now 🙏

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.84%. Comparing base (7267686) to head (3fc0157).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   72.84%   72.84%           
=======================================
  Files          18       18           
  Lines        1204     1204           
  Branches      113      113           
=======================================
  Hits          877      877           
  Misses        327      327           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JohanMabille JohanMabille left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to track the port of changes made to clad

@JohanMabille
JohanMabille merged commit 2bddf45 into compiler-research:main Sep 23, 2026
18 checks passed
@anutosh491
anutosh491 deleted the fix/clang-tidy-ci branch September 23, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants