Fix clang-tidy dependency setup - #494
Merged
JohanMabille merged 2 commits intoSep 23, 2026
Merged
Conversation
4 tasks
anutosh491
force-pushed
the
fix/clang-tidy-ci
branch
from
September 23, 2026 06:34
3d3e96e to
9e65d28
Compare
Contributor
|
You can take a look how this was done in clad -- we can port the changes here too, I believe. |
Collaborator
Author
Ahh okay I can move to how clad does it later. For now my goal is to just fix some issues/ci on xeus-cpp for my talk next week. These changes were some obvious improvements I could see (like moving micromamba from 1.5 to 2.8 etc & also the clang-tidy job was failing anyways). Hopefully this should be fine for now 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 72.84% 72.84%
=======================================
Files 18 18
Lines 1204 1204
Branches 113 113
=======================================
Hits 877 877
Misses 327 327 🚀 New features to boost your workflow:
|
JohanMabille
approved these changes
Sep 23, 2026
JohanMabille
left a comment
Collaborator
There was a problem hiding this comment.
Let's open an issue to track the port of changes made to clad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As seen in the last 2 prs #493 #492 this job is failing
The clang-tidy job has been failing before CMake or clang-tidy runs because
ZedThree/clang-tidy-review@v0.23.1attempts to install additional APT packages inside its Ubuntu 25.10 container. That installation exits with status 100.This updates and simplifies the clang-tidy environment setup:
apt_packagesinstallation.1.5.10-0to2.8.1-0.micromamba runinstead of installing shell hooks and activating the environment.environment-dev.yml, matching the clang-tidy 21 toolchain.Type of change
Please tick all options which are relevant.