build(deps): bump agp from 9.3.2 to 9.4.0 - #1421
Merged
Merged
Conversation
Dependabot opened #1413 for this, then closed it when asked to rebase, saying the dependency was up to date. It was reading its own branch rather than the base: code/cash is on 9.3.2 and 9.4.0 is published, so the bump still applies. Redoing it by hand rather than fighting the bot. A release bundle off this branch links and shrinks. That matters more than usual here, because CI builds debug only and never runs R8, which this project uses in full mode.
github-actions
Bot
added
area: build-system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1413. Dependabot opened that PR for the same bump, then closed it in response to a
@dependabot rebasewith "Looks like these dependencies are up-to-date now, so this is no longer needed." It was evaluating its own branch, which already carried 9.4.0, rather than the base.code/cashis on 9.3.2 andcom.android.tools.build:gradle:9.4.0is published, so the bump still applies. A@dependabot reopendid not bring it back, hence this branch.The change is the
agpversion in the catalog, which drivescom.android.application,com.android.library,com.android.kotlin.multiplatform.libraryandcom.android.tools.build:gradle.:apps:flipcash:app:bundleReleaselinks and shrinks off this branch, withminifyReleaseWithR8executing rather than resolving up to date. That is worth doing by hand for an AGP bump:flipcash_testsbuildsflipcashTestDebugandlintDebugonly, so CI never exercises R8, and this project setsandroid.enableR8.fullMode=true. The build emits the same warning set as 9.3.2 — six pre-existingpackage-attribute manifest notices, nothing new — and the bundle is 14KB larger, which is noise rather than a shrinking regression.Worth noting that #1408 landed between Dependabot's PR and this one, so this branch is the first release build covering AGP 9.4.0 together with
androidx-benchmark-macro1.5.0-rc02. The two share a plugin surface throughandroidx.baselineprofile, which the app module applies.