fix(ci): pass the release keystore to Gradle as an absolute path - #1426
Merged
Conversation
The release build has failed since the AGP 9.4.0 bump:
Execution failed for task ':apps:flipcash:app:validateSigningRelease'.
> Keystore file '/home/runner/.gradle/daemon/9.7.1/key/key' not found
for signing config 'externalOverride'.
`base64-to-file` reports a workspace-relative `key/key`, which the workflow
passed straight through as `android.injected.signing.store.file`. AGP resolves
that property against the Gradle daemon's working directory rather than the
project, so it looked for the keystore under `~/.gradle/daemon/9.7.1/`.
Prefix the path with `github.workspace`. That also retires the second decode
into `apps/flipcash/app/key/` — it only existed to cover the module-relative
resolution, and nothing in the build reads that location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flipcash2 Build and Deployhas failed since the AGP 9.4.0 bump (#1421). The last green release run was on 4 Sep, before that landed; run 34237943672 dies inbuild-release:timheuer/base64-to-filereports a workspace-relative path, so the workflow was handing Gradle-Pandroid.injected.signing.store.file=key/key. AGP resolves that property against the Gradle daemon's working directory rather than the project directory, which is how the lookup ended up under~/.gradle/daemon/9.7.1/.Prefixing the value with
github.workspaceremoves the resolution question entirely — nothing downstream has to guess a base directory, including thebundletoolcall that reusesSTORE_FILEasks_path.That also lets the second decode step go.
apps/flipcash/app/key/only existed to cover module-relative resolution; no signing config or script reads it. Thecontributorsconfig is unaffected — it builds its path fromrootDir.