atmel-samd: send INVOFF (0x20), not 0x2a, in ST7735 init sequences - #11429
Merged
Merged
Conversation
The six ST7735 boards labelled the command _INVOFF but sent 0x2a (CASET) with no parameters. Use 0x20 like the other in-tree ST7735 boards and adafruit_st7735r.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six ST7735 boards (
hallowing_m0_express,pewpew_lcd,pewpew_m4,pybadge,pygamer,ugame10) have0x2a, 0, // _INVOFFin their init sequence.0x2ais CASET not INVOFF - it should be0x20.The panel comes out of SWRESET with inversion off, so the wrong byte had no visible effect. CASET with no parameters is harmless too; the real CASET follows later in the sequence.
Tested on PyBadge.