Skip to content

Toolbar: remove white background from transparent site icon - #13289

Open
fushar wants to merge 1 commit into
WordPress:trunkfrom
fushar:site-icon-transparent
Open

Toolbar: remove white background from transparent site icon#13289
fushar wants to merge 1 commit into
WordPress:trunkfrom
fushar:site-icon-transparent

Conversation

@fushar

@fushar fushar commented Aug 27, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65974

This PR removes white background from transparent site icons. This is done so that site icons maintain their original shape.

I actually implemented the initial background color so that the site icons are consistently square, but now that the feature is live and I've seen some client sites, I think it's a mistake. In some brands, the shape of a transparent site icon gets weird with the added white rounded square.

With this change, these 4 places are now consistent:

  • toolbar
  • browser tabs (at least Chrome and Firefox show transparent favicons as-is)
  • Settings -> General site icon preview
  • Site Editor -> Identity -> Site Icon form input

Solid site icon (no change)

Toolbar

image

Settings -> General

image

Site Editor -> Identity

image

Actual browser Chrome tab

image

Transparent site icon

Toolbar - BEFORE vs AFTER

image
image

Settings -> General - BEFORE vs AFTER

image
image

Site Editor -> Identity

image

Actual browser (Chrome) tab

image

Use of AI Tools

Used Claude Code, Opus 5 to help generate the CSS changes.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@jasmussen

Copy link
Copy Markdown

This feels valid to me. It's good to have the square silhouette for site logos when any arbitrary image is used, but we shouldn't necessarily enforce a square shape for logos that feature transparency.

@fushar
fushar marked this pull request as ready for review August 27, 2026 08:44
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props fushar, joen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants