Skip to content

Remove dark background on the Admin Bar site icon - #13229

Open
audrasjb wants to merge 1 commit into
WordPress:trunkfrom
audrasjb:65924
Open

Remove dark background on the Admin Bar site icon#13229
audrasjb wants to merge 1 commit into
WordPress:trunkfrom
audrasjb:65924

Conversation

@audrasjb

@audrasjb audrasjb commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb, fushar, ugyensupport.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@audrasjb

audrasjb commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Tested using a semi-transparent PNG set as the site icon.
Before:
Capture d’écran 2026-08-21 à 22 36 23

After:
Capture d’écran 2026-08-21 à 22 36 39

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@fushar

fushar commented Aug 27, 2026

Copy link
Copy Markdown

Can we also update the site icon preview in Settings -> General? See this PR, which I worked on independently before seeing this PR 😄

#13289

@dugyen

dugyen commented Aug 27, 2026

Copy link
Copy Markdown

Tested against local Studio (WP trunk/SQLite)

Verified the fix works as intended.

Setup: Applied the patch to both admin-bar.css and the minified admin-bar.min.css (the admin bar loads the concatenated/minified bundle via load-styles.php). Set a semi-transparent PNG as the site icon and measured the icon's computed background-color:

State Computed background-color
Before patch rgb(240, 240, 241) (#f0f0f1)
After patch rgba(0, 0, 0, 0) (transparent)

Before/after:

Before After
light-gray square visible behind icon icon blends cleanly into the dark admin bar

Note for other testers: if you're testing on a site with the Gutenberg plugin active, its command-palette.php compat shim inlines its own stale duplicate of the admin-bar CSS (including the old #f0f0f1 rule) directly into a <style> tag in <head>. That masks this fix — the background will still appear even with the patch correctly applied to core. Deactivating Gutenberg confirmed the core fix is correct in isolation.

Also checked admin-bar-rtl.css, which still has the old rule — expected, since RTL files are build-generated (RTLCSS), not hand-edited per PR.

No regressions found in the surrounding admin-bar rules. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@audrasjb @fushar @dugyen