Repository navigation
Fix reauthentication when Hive device authentication expires - #237
Closed
bigshow104 wants to merge 2 commits into
Closed
bigshow104 wants to merge 2 commits into
bigshow104 wants to merge 2 commits into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds
HiveInvalidDeviceAuthenticationto the exceptions handled incustom_components/hive/__init__.py.When a Hive refresh token expires, the API attempts to log in again but may raise
HiveInvalidDeviceAuthenticationbecause SMS two-factor authentication is required.Currently, this exception is not caught, causing the Hive integration to fail setup without triggering Home Assistant's reauthentication flow.
By catching this exception and raising
ConfigEntryAuthFailed, Home Assistant correctly displays the Reauthenticate prompt.This preserves the existing integration, devices and entity IDs without requiring removal or reinstallation.
Related issues
Related to #224.
Testing
Successfully tested on two separate Home Assistant installations:
Checklist
script/testpassesscript/lint --checkpassesversioninmanifest.jsonNote: The fix has been tested manually on two installations. Automated tests and lint checks have not yet been run.