Repository navigation
Fix Hive reauthentication on invalid device authentication - #238
Open
bigshow104 wants to merge 1 commit into
Open
bigshow104 wants to merge 1 commit into
bigshow104 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds
HiveInvalidDeviceAuthenticationto the exception handling incustom_components/hive/__init__.py.When the Hive refresh token expires, the integration attempts to log in again. If Hive requires SMS two-factor authentication, the API can raise
HiveInvalidDeviceAuthentication.Previously, this exception was not handled, causing integration setup to fail without triggering Home Assistant's reauthentication flow.
The change raises
ConfigEntryAuthFailedfor this exception, allowing Home Assistant to display the existing Reauthenticate prompt without removing the integration or losing its devices and entities.Related issues
Related to #224.
This PR replaces #237 to ensure the change is submitted with a verified, signed commit.
Testing
Successfully tested manually on two separate Home Assistant installations:
Checklist
script/testpassesscript/lint --checkpassesversioninmanifest.jsonAutomated tests and lint checks have not been run. The fix has been verified manually on two installations.