Repository navigation
Conversation
Make the OpenCombine dependency follow the same switch as the other dependencies, so a local multi-repository build resolves ../OpenCombine instead of the remote package. (cherry picked from commit 2cf8efa)
Author
|
Cold review: code clean (guards balanced, matches the useLocalDeps style). Unverified risk noted by the reviewer: older compilers may check only the top-level module in canImport(A.B), in which case #1247 would have no effect on the target SDK. Not compiled. |
Member
|
I do not think we need this for now as we use Combine by default on apple OS. You can keep it in your fork. Will consider it when we add OpenCombineShims and reduce the xcframework cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC, draft, unbuilt. Use ../OpenCombine when USE_LOCAL_DEPS is set, like the other dependencies in Package.swift.
Verification
Run: the commit cherry-picks cleanly onto current main. Not run: no Swift, C or Objective-C compiler was available on the machine used, so this was not compiled and CI is the first real check.
CONTRIBUTING.md asks for an issue or discussion first for large work; this PR is a single small concern. Related RFC draft: #1246.