Repository navigation
Conversation
…rtzCore DisplayLink.c only needs CACurrentMediaTime. Importing the QuartzCore umbrella pulls Objective-C layer declarations into this C translation unit, which does not compile on SDKs whose umbrella is Objective-C only. Declare the one function the file uses. (cherry picked from commit 2cf8efa)
Author
|
Cold review: code clean (CFTimeInterval and the signature match). Body contradiction fixed; the commit message overclaim is disclosed in the body because the branch cannot be rewritten without a force push. Not compiled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC, draft, unbuilt. Declare CACurrentMediaTime in DisplayLink.c instead of importing the QuartzCore umbrella; the file uses no other QuartzCore symbol and CFTimeInterval comes from CoreFoundation via DisplayLink.h.
The commit message says the umbrella import fails to compile on SDKs whose umbrella is Objective-C only. That was seen in an earlier build of my fork and not reproduced here; read it as unverified.
Verification
Run: cherry-picks cleanly onto current main (the original commit also changed Package.swift, split out as #1250, hence the shared source SHA). Not run: no compiler was available. CONTRIBUTING.md asks for an issue first for large work; this is one concern. Related RFC draft: #1246.