Skip to content

feat(shell): give observers their own sidebar and command palette - #2550

Open
Makisuo wants to merge 3 commits into
observer/membersfrom
observer/shell
Open

feat(shell): give observers their own sidebar and command palette#2550
Makisuo wants to merge 3 commits into
observer/membersfrom
observer/shell

test(shell): pin the observer shell's missing setup rows and Connect …

5f07072
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 13, 2026 in 58s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The only new hunk is a scene test that pins both observer removals in both directions, and no other file moved since the last pass.
no findings · tests covered · risk medium

Adds a lab scene test that pins the observer shell's two removals — the Sources/Settings footer rows and the top bar's Connect button — by driving the new Viewer toggle, which closes the earlier gap. Safe to merge.

What was checked
  • The Observer option is a real toggle button named by its label (segmented-select.ts:179), so click reaches Message.ClickedViewer.
  • Member half renders Connect (view-topbar.ts:109) and the footer rows; observer half drops both (view.ts:198, view-sidebar.ts:409).
  • shellAudience maps the fixture's org:observer through Policy.isReadOnly (policy/index.ts:55), so the lab matches the deployed shell.

5f07072 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot