Repository navigation
Conversation
An observer follows the product without operating it, so the shell shows them the pages that answer whether it works and how it is doing: incidents with uptime and SLOs, errors, status pages, web analytics, users, replays, dashboards, releases and cost. The explorers, infrastructure, alert setup, review, security, Sources, Settings and the Connect button are left out. The command palette lists the same pages plus dashboards and the app actions. Other pages still open from a link: nothing is redirected, and the API refuses any change. The shell lab gains a viewer toggle to draw the sidebar for an observer.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This comment has been minimized.
This comment has been minimized.
![maple-review-bot[bot]](https://avatars.githubusercontent.com/in/4108169?s=60&v=4){kind=small}
An observer's sidebar calls the alerts inbox Incidents, but the palette built its rows from the full nav, so it listed that page as Alerts and a search for incidents found nothing. Their entries now carry the observer nav's titles; the ids are unchanged, so a pick resolves the same way.
This comment has been minimized.
This comment has been minimized.
Maple review🟢 Confidence 10/10 · safe to merge. The only new hunk is a scene test that pins both observer removals in both directions, and no other file moved since the last pass. Adds a lab scene test that pins the observer shell's two removals — the Sources/Settings footer rows and the top bar's Connect button — by driving the new Viewer toggle, which closes the earlier gap. Safe to merge.
|
Fifth layer of the Observer role, on top of #2549. Observers get a sidebar and command palette built around what they come for.
What changed
/lab/shellhas a Viewer toggle that draws the shell for an observer.Self-hosted has no observers, so its shell is unchanged.
Screenshots
Incidents opens to its three pages:
Verified
apps/web: the shell tests and the shell lab scene test, 133 passed. New cases: the observer nav links to exactly its pages and to no setup or explorer page, rollout flags add Status pages, Releases and Cost, an uptime page marks only Incidents, the palette finds an observer's pages and dashboards but not Traces, services, Connect entries or Settings, and Enter opens the page they see highlighted.@maple/webtypecheck, the CI lint config on the changed files, and the UI class pattern check./lab/shelldriven in a headless browser for the screenshots.Next
The pages an observer reaches still draw their write controls (the API refuses them). The next layer hides those, and the one after gives observers their own Overview.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.