Comma after the introductory phrase, in the three places missing one - #224
Merged
Merged
Conversation
davidmckayv
requested review from
MikeRyanDev,
guidovizoso and
tylerslaton
as code owners
August 24, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three separate reports from @lunar-me — #221, #222 and #223 — one comma each in
docs/deployment.md:Without it, every Bot shares the one browserWith no identity provider configured, the deployment refuses to startWith an external database, they are a release stepAll three are correct: an introductory phrase before the main clause takes a comma.
Taken together in one change because each of those PRs also carried two edits that are already on main — the
240-secondhyphen landed in #170, anddoes not dependis already there. So each was one useful line and two no-ops against a stale base, and rebasing three PRs would have produced three near-empty diffs touching the same file.Credit is @lunar-me's; the three PRs are being closed pointing here.