Skip to content

Fix grammar: add missing comma after introductory phrase in deployment.md - #222

Closed
lunar-me wants to merge 1 commit into
CopilotKit:mainfrom
lunar-me:fix-docs/issue-006
Closed

Fix grammar: add missing comma after introductory phrase in deployment.md#222
lunar-me wants to merge 1 commit into
CopilotKit:mainfrom
lunar-me:fix-docs/issue-006

Conversation

@lunar-me

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a grammar issue in docs/deployment.md (line 82).

Problem

Missing comma after the introductory phrase "With no identity provider configured".

The problematic text:

With no identity provider configured the deployment refuses to start

Fix

Replaced with:

With no identity provider configured, the deployment refuses to start

Type of Change

  • Documentation fix (grammar, spelling, logical error)
  • Code change
  • Breaking change

Checklist

  • Documentation files only
  • No code changes
  • Fix verified against original text

davidmckayv added a commit that referenced this pull request Aug 24, 2026
…224)

Reported across #221, #222 and #223 by lunar-me, one comma each. Taken
together here because each of those also carried two changes already on
main, so three rebases would have produced three near-empty diffs.
@davidmckayv

Copy link
Copy Markdown
Contributor

Thanks — the comma you spotted is correct and has landed, in #224 together with the other two you reported.

Closing rather than merging because all three of these were built on a stale main. Each carried one genuinely missing comma plus two edits that are already there: the 240-second hyphen landed in #170, and does not depend is already the wording. So rebasing three PRs against the same file would have produced three near-empty diffs.

Credit is yours; the fix is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants