Skip to content

PNE-9649: Remove allowed_names from ProcessTemplate #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wjohnald wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

PNE-9649: Remove allowed_names from ProcessTemplate #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
811c913
PNE-9649: Deprecate allowed_names on ProcessTemplate
wjohnald Nov 12, 2026
8477ce6
PNE-9649: Remove allowed_names from ProcessTemplate
wjohnald Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dependencies = [
"requests>=2.32.2,<3",
"pyjwt>=2,<3",
"arrow>=1.0.0,<2",
"gemd>=3,<4",
"gemd>=4,<5",
"boto3>=1.34.35,<2",
"deprecation>=2.1.0,<3",
"urllib3>=2.5.0,<3",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
arrow==1.4.0
boto3==1.43.36
deprecation==2.1.0
gemd==3.0.0
gemd==4.0.0
pyjwt==2.15.0
requests==2.34.2
tqdm==4.68.3
Expand Down
2 changes: 1 addition & 1 deletion src/citrine/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "5.2.0"
__version__ = "6.0.0"
3 changes: 0 additions & 3 deletions src/citrine/resources/process_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ class ProcessTemplate(
parameters = Optional(List(_attr_tuple(GEMDParameterTemplate)), "parameters", override=True)

allowed_labels = Optional(List(String()), "allowed_labels", override=True)
allowed_names = Optional(List(String()), "allowed_names", override=True)

def __init__(
self,
Expand All @@ -85,7 +84,6 @@ def __init__(
]
| None = None,
allowed_labels: list[str] | None = None,
allowed_names: list[str] | None = None,
description: str | None = None,
tags: list[str] | None = None,
):
Expand All @@ -101,7 +99,6 @@ def __init__(
tags=tags,
description=description,
allowed_labels=allowed_labels,
allowed_names=allowed_names,
)

def __str__(self):
Expand Down
1 change: 0 additions & 1 deletion tests/serialization/test_object_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def test_object_template_serde():
parameters=[index_template],
conditions=[pressure_template],
allowed_labels=["Label"],
allowed_names=["first sample", "second sample"],
)
assert ProcessTemplate.build(proc_template.dump()) == proc_template

Expand Down
2 changes: 0 additions & 2 deletions tests/serialization/test_process_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def valid_data():
]
],
"allowed_labels": ["a", "b"],
"allowed_names": ["a name"],
"description": "a long description",
},
file_links=[{"type": "file_link", "filename": "cake_recipe.txt", "url": "www.baking.com"}],
Expand Down Expand Up @@ -103,7 +102,6 @@ def test_simple_deserialization(valid_data):
],
description="a long description",
allowed_labels=["a", "b"],
allowed_names=["a name"],
)
assert process_spec.name == "Process 1"
assert process_spec.notes == "make sure to use oven mitts"
Expand Down
Loading