Repository navigation
Conversation
The platform no longer stores or returns process-template allowed_names. Ingredient names for tables now come from ingredient specs. Keep the argument and the field so constructors and loaders stay compatible, and warn when a caller passes a non-empty list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The platform no longer stores or returns process-template allowed_names, and gemd 4.0.0 drops the field. Remove the field and the constructor argument from ProcessTemplate, require gemd 4, and bump to 6.0.0 for the breaking change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on CitrineInformatics/gemd-python#242
Citrine Python PR
Description
Epic PNE-9643 retires process-template
allowed_names. The server ignores the field on create requests and leaves it out of responses. Tables take ingredient names from ingredient specs.A caller that passes
allowed_namestoProcessTemplategets aTypeErrorafter this change. I bumped the major version to 6.0.0 for that reason.allowed_namesfield and constructor argument fromProcessTemplate.This PR waits on gemd-python #242. That PR must merge, and gemd 4.0.0 must reach the package index. Until then, CI fails when it installs dependencies.
I installed the gemd 4.0.0 branch from a local checkout, and the full suite, flake8, and derp pass with 100% coverage.
PR Type:
Adherence to team decisions
🤖 Generated with Claude Code