Dev - #9
Merged
Merged
Dev#9
Conversation
Seems like the game passes nullptr in some situations
this has been wrong for a while but funchook didn't seem to care
- Overhauled map migrations to fix an out-of-bounds rendermode issue & run cleanly during map load when possible, similar to Stripper - Overhauled the custom cfg parser to skip the command buffer, and process changes immediately - Added an additional early cfg execution, to ensure map migrations has access to correct cvar values for the upcoming map
Index-based rendermodes only come from the S1 map importer. S2 Hammer always uses enum-named render modes, so we can confidently assume that new maps will not be caught off by this, while we can also extend this migration to new/recently updated ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.