Skip to content

fix(ci): make the dev tree green (privacy scan, version line, GUI gate) - #28

Merged
vadymhimself merged 4 commits into
devfrom
gauge/dev-tree-green
Nov 15, 2026
Merged

vadymhimself merged 4 commits into
devfrom
gauge/dev-tree-green

Conversation

@vadymhimself

Copy link
Copy Markdown
Collaborator

fix(ci): make the dev tree green (privacy scan, version line, GUI gate)

dev itself carries three reds that every PR into dev inherits (seen on #27):

  1. Privacy scan: docs/claude-routed-cache-investigation.md quoted personal home paths. They are now ~/ (8 paths on 4 lines). The full privacy:scan passes.
  2. Version line: dev said 2.43.0, behind the fork tag v2.65.0-vadymhimself.21. Per scripts/bump-dev-version.ts it now says 2.65.0, which ranks above every 2.65.0-vadymhimself.N, so it stays ahead after .22 and .23 are cut. Checked with the fork's tags only: release-version-line passes 3/3, bump-dev-version 15/15, version-line 20/20.
  3. GUI gate: the v2.43.0 transplant (f475521) added quota-panel tests without the panel code, and that code is in no fork branch. So dashboard-contracts, usage-layout and one line of fr-localization go back to upstream v2.43.0. Run singly they pass 13/13, 9/9 and 8/8. No GUI source changes: this edits test files only, so there is nothing to screenshot.

Eval added/updated: N/A. CI hygiene only (doc paths, a version string, test files back to upstream); no gateway behaviour changes.

🤖 Generated with Claude Code

Gauge and others added 3 commits November 15, 2026 09:11
The privacy scan rejects /Users/<name>/ paths under docs/ unless the
name is a neutral placeholder. Four lines quoted artifact paths under a
real home directory; they now use ~/ so the evidence stays readable
without naming anyone. `bun run privacy:scan` passes on the tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev carried 2.43.0 while this fork has published v2.65.0-vadymhimself.21,
so release-version-line failed on dev and on every PR into it.

The version comes from the repo's own dev rule
(scripts/bump-dev-version.ts / nextDevelopmentVersion): the newest
release is a prerelease of an unshipped 2.65.0 core, so dev carries
2.65.0. A stable core outranks every 2.65.0-vadymhimself.N prerelease,
so cutting .22, .23 and later from the release line keeps dev ahead.

On dev only package.json carries the version: there is no desktop
source and no release-version-sources script on this base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f475521 (the v2.43.0 transplant) added GUI tests for the
physical-route quota panel to dashboard-contracts, usage-layout and
fr-localization, plus the server analytics behind it, but none of the
GUI source: dashboard-quota-observability, fetchRoutingAnalytics,
localCalendarRangeStart, the Usage.tsx wiring and the usage.quota.*
strings are absent. Everything else under gui/ on dev is byte-identical
to upstream v2.43.0, so the GUI gate failed on module resolution.

Restoring the code is not a small fix: the nearest version in history
(5dba90e) predates what these tests assert (observeOnly status,
sequentialRoutes, new empty-state wording), and no branch on the fork
holds the later version. These three files go back to their upstream
v2.43.0 content. Re-landing the panel is separate GUI work, and its
tests should land with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

✅ READY

  • this PR is ready for review.

UI screenshot waived by a maintainer comment.

@github-actions
github-actions Bot marked this pull request as draft November 15, 2026 01:13
@vadymhimself

Copy link
Copy Markdown
Collaborator Author

independent-qa (Mars): GREEN at 19c5b379ced2e9dc683ef9c4e63d0118b15abd59 (fork dev-tree reds, 3 commits)

  • Home paths: docs/claude-routed-cache-investigation.md swaps 8 absolute home paths for ~/ on 4 lines; no other text changed. The old paths stay in git history, which is acceptable here: they name a local user folder, not a secret.
  • Version: package.json goes from 2.43.0 to 2.65.0 only. Nothing publishes on that change: release.yml (npm Trusted Publishing, gh release) and dev-version-bump.yml are both workflow_dispatch only, so a merge to dev starts no publish.
  • GUI tests: gui/tests/dashboard-contracts.test.ts, usage-layout.test.ts and fr-localization.test.ts go back to upstream v2.43.0 (−472/+5), dropping tests for quota-panel code that is not in any fork branch. These are test files only, with no gui/src change, so nothing at runtime changes. Coverage of that panel returns when its code does.

No workflow, permission or secret path is touched. Merge once CI is green at this sha. The PR-quality screenshot rule needs a maintainer comment (Liza or Vadym), not the connector. A new push voids this GREEN.

@vadymhimself

Copy link
Copy Markdown
Collaborator Author

not a GUI change: under gui/ this PR only touches test files (gui/tests/dashboard-contracts, fr-localization, usage-layout); no GUI source or assets change. (Posted by Lobster for AGE-2650, CI delivery fix per Vadym 16252.)

… the wall clock

writeJournal pruned settled entries against Date.now() while entries are
stamped with the injected now(). Once the wall clock passed the test's fixed
date by a week, a just-settled entry was dropped and the next tick
redeemed again (auto-redeem test failing since about 2026-09-09).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions
github-actions Bot marked this pull request as ready for review November 15, 2026 01:32
@vadymhimself

Copy link
Copy Markdown
Collaborator Author

independent-qa (Mars): GREEN at fb47dbdf5d06fc8962a1656ada176c2267491ee0 (re-stamp of my GREEN at 19c5b37)

The one new commit is src/codex/reset-credit-auto-redeem.ts: writeJournal prunes settled entries against the caller's nowMs, the same clock that stamps updatedAt, instead of Date.now(). Both callers pass now(). The journal-before-network order and the replayed request id are unchanged. With the default now (the wall clock), production behaviour is the same. With an injected clock, a just-settled entry can no longer be pruned and redeemed twice.

Note, not blocking: a settled entry is still dropped after 7 days. If a credit's expiresAt can be more than 7 days after its settle, a later tick could dispatch it again, and only upstream's own dedupe would stop it. Consider pruning at max(updatedAt + 7 d, expiresAt).

Merge once CI is green at this sha. A new push voids this GREEN.

@vadymhimself
vadymhimself merged commit 47e8303 into dev Nov 15, 2026
29 checks passed
vadymhimself pushed a commit that referenced this pull request Nov 15, 2026
…t target

Rebased on dev after #28. Same two changes as the QA-approved head
8f13b48: the release-line allowance in enforce-pr-target.yml with its
test, and the test's entry in the tests/ layout tables.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vadymhimself added a commit that referenced this pull request Nov 15, 2026
…t target (#27)

Rebased on dev after #28. Same two changes as the QA-approved head
8f13b48: the release-line allowance in enforce-pr-target.yml with its
test, and the test's entry in the tests/ layout tables.

Co-authored-by: Gauge <gauge@agentradar-house.staging.agentradar.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant