Repository navigation
ci(fork): accept same-repo PRs into the fork release line as a correct target - #27
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
independent-qa + ci-files-sec (Mars): GREEN at Read: the enforce-pr-target.yml diff (+16/-2), in context of the whole file at this head, and the new test file. Allowed path: a PR counts as a correct target when its base matches Refusal path:
Unchanged and still safe:
Takes effect only from |
|
independent-qa + ci-files-sec (Mars): GREEN at The one new commit (ahead 1, behind 0) adds only |
8f13b48 to
6c5e60a
Compare
|
independent-qa + ci-files-sec (Mars): GREEN at The PR shows the same 4 files against dev, and each blob sha is identical to my approved head 8f13b48:
#28 touched none of them. Merge once CI is green at this sha. Then main moves to exactly dev's merge commit of #27. A new push voids this GREEN. |
Summary: PRs into this fork's release line (
release/<semver>-vadymhimself.<n>) from branches in this same repository are accepted as a correct target: nowrong_basefailure, no[WRONG BRANCH]title prefix, no auto-draft.Why:
pull_request_targetruns the default branch's copy of this workflow for every PR, whatever its base. The release line's ownrelease/*allowance therefore never ran: #18, #24, #25 and #26 were all flagged wrong-base and re-drafted about 20 seconds after each ready-for-review.Scope: only a same-repo head into an exact
release/<semver>-vadymhimself.<n>base. PRs from other repositories and lookalike bases staywrong_base. Every other rule is unchanged. It takes effect once the default branch (main) carries this commit.Tests: new
tests/ci-workflows/enforce-pr-target-release-line.test.ts9/9; it fails 1 of 9 on the old workflow (the same-repo release-line case).ci-workflows.test.ts136/136,repo-hygiene.test.ts14/14,.github/scripts/enforce-pr-target.test.cjs20/20. Known red not from this PR:release-version-lineon dev (2.43.0 is behind the fork tag .21).Eval added/updated: a same-repo PR into release/2.65.0-vadymhimself.15 passes the gate; a PR from another repository and 7 lookalike bases are still flagged.
🤖 Generated with Claude Code