Fix github repo stats rendering twice, and fix them in the nav drawer - #68
Merged
Merged
Conversation
The header showed the repo stats twice on a cold page load. Our source.html override kept upstream's data-md-component="source", so Material mounted its own fact-fetching on the same element repo-source.js writes to, and both appended a list. Material's mount runs once at bundle-eval time and never again, which is why the duplicate disappeared as soon as a navigation repainted the element. Marking the link with data-repo-source instead leaves repo-source.js as the only writer, and halves the GitHub API calls per cold load from four to two. The partial also renders a second time in the navigation drawer, the copy shown below 960px, which repo-source.js never patched because it used a singular querySelector. Its facts came from Material's session-wide cache and could be another project's, and instant navigation replaces that node, so they vanished entirely after the first in-project navigation. Both copies are now re-queried and repainted on each navigation rather than captured once, and the route's resolved facts are memoised so the extra repaints cost no requests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header showed the repo stats twice on a cold page load. Our source.html override kept upstream's data-md-component="source", so Material mounted its own fact-fetching on the same element repo-source.js writes to, and both appended a list. Material's mount runs once at bundle-eval time and never again, which is why the duplicate disappeared as soon as a navigation repainted the element. Marking the link with data-repo-source instead leaves repo-source.js as the only writer, and halves the GitHub API calls per cold load from four to two.
The partial also renders a second time in the navigation drawer, the copy shown below 960px, which repo-source.js never patched because it used a singular querySelector. Its facts came from Material's session-wide cache and could be another project's, and instant navigation replaces that node, so they vanished entirely after the first in-project navigation. Both copies are now re-queried and repainted on each navigation rather than captured once, and the route's resolved facts are memoised so the extra repaints cost no requests.