Conversation
The pages rs list now renders through the same ui/rs/contentlist components as the posts list, so the two cannot drift apart, and the experimental feature is relabelled to say it covers both.
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
A pull-to-refresh evicted the empty view-count entries without asking for them again, so those rows kept their skeleton with nothing left to resolve it. The in-flight claim is also only taken once a semaphore permit is granted, so a page queued twice could be fetched twice. Moves ContentListMenuAction next to the row state so the menu file no longer trips detekt's MatchingDeclarationName.
Inlines locals that were read once, hoists the row callbacks the redesigned and legacy branches were both declaring, and states the homepage badge condition directly. No behaviour change.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #23344 +/- ##
==========================================
- Coverage 38.00% 38.00% -0.01%
==========================================
Files 2272 2275 +3
Lines 127689 127940 +251
Branches 17979 18033 +54
==========================================
+ Hits 48527 48619 +92
- Misses 75161 75302 +141
- Partials 4001 4019 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The pager composes the neighbouring tab during a drag and its visible-row stream reports against that tab, so a single shared set was overwritten by the neighbour. The active tab's queued view-count fetches then re-checked that set once a permit freed, found the wrong ids and were dropped with nothing left to retry them, and a later refresh handed the retry another tab's ids.
nbradbury
marked this pull request as ready for review
September 18, 2026 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Puts the wordpress-rs pages list behind the same Posts list redesign experimental feature as #23316 — cards, filter chips, the density toggle — and relabels the feature Posts and Pages list redesign. The pages list renders through the shared
ui/rs/contentlist/components rather than growing a second copy.Two caveats to note:
These will each be handled separately.
Testing instructions
android_wp_rs_wpcomon.Views on a WordPress.com site:
Self-hosted site:
Density toggle: