markdown: replace cmark with cmark-gfm for GFM tables - #1373
Merged
Merged
Conversation
Vendor github/cmark-gfm 0.29.0.gfm.13 and enable table, strikethrough, autolink, tagfilter, tasklist, and footnotes in the HTML converter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the vendored CommonMark
cmark0.29.0 parser with cmark-gfm 0.29.0.gfm.13 so Markdown preview can render GFM tables and related syntax.md2html()keeps the same API. The converter now registers GFM extensions and options:CMARK_OPT_GITHUB_PRE_LANGAlso add basic table/
delstyles for the QTextBrowser preview CSS.Verified with a standalone conversion of tables, strikethrough, task lists, autolinks, and footnotes to HTML, and rebuilt the Qt6
libcmark.aplus markdown/welcome plugins.