Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
None.
Description:
Thumbnail.onSetupcreated theThumbnailsLoaderbefore#watchCrossOrigin()had resolved the effective cross-origin value. Effects run synchronously on creation, so the loader's first run read the initial state (null) and fetched the storyboard withcredentials: 'same-origin'; when the watcher then set the real value, the effect re-ran and fetched again: two requests per mount, the first one failing with 403 for cookie-protected media.Swapping the two lines makes the loader read the correct value on its first run, matching the order
SliderVideoalready uses.SliderThumbnailis covered too, since it extendsThumbnail.Added
thumbnail-cross-origin.test.ts: it mounts aThumbnailwith the media'scrossOriginset touse-credentialsand asserts a singlefetchwithcredentials: 'include'. Without the fix it fails with two calls.Ready?
Yes.
Anything Else?
Nothing.
Review Process:
pnpm -F vidstack sandbox.storyboard.vttand clear the list.Before: two requests. After: one.