Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luismeyer
added this pull request to stack #512
September 23, 2026 13:34
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #511 (
codex/flags-header-source).The client currently exposes little detail about why it serves cached definitions, refreshes, or changes connection state. Set
DEBUG=@vercel/flags-coreto emit detailedconsole.debugdiagnostics using the existing debug namespace.The controller, cache, and network sources import one shared
debug()function. It checks the environment variable on each call and computes details lazily. Events cover mode/state transitions, initialization and shutdown, read and snapshot results, cache versions/age and acceptance, header freshness and fallback, background/blocking/shared refreshes, stale-if-error expiry and recovery, HTTP status, polling, stream pings/timeouts, and reconnect delays.Logging is off by default. The new logs omit credentials, raw headers, definitions, evaluation entities, and raw error messages; a throwing console cannot interrupt client operations. Includes usage documentation and a patch changeset. Event names and fields remain internal diagnostics.
Validation: existing flags-core regression suites, TypeScript, and Biome passed for the logger implementation (live-service integration suite excluded). The logger-specific test file was subsequently removed; the deletion was reviewed and
git diff --checkpassed. Tests were not rerun for the deletion. Review found no substantive issues.