Repository navigation
perf_hooks: lower PerformanceNodeTiming and the performance object's properties - #3609
Merged
Merged
Conversation
…properties performance.nodeTiming answers PerformanceNodeTiming's own fields in Node's key order (name, entryType, startTime, duration, the startup milestones, the loop milestones, idleTime, uvMetricsInfo), its toJSON() and the JSON stringify writes through it, inspection, and the missing runtime metrics: scr_perf_loop.c gains the loopExit and loopCount getters the record and the event-loop metrics read, and scr_json.c builds nodeTiming's JSON from toJSON's field list. PerformanceObserver.supportedEntryTypes is Node's fixed list as one frozen static array: every read answers the same array, a checked-dynamic read observes the same frozen array, and writes throw Node's TypeError messages. performance.toJSON() answers nodeTiming, timeOrigin and the event-loop utilization in Node's key order, and perf_hooks.eventLoopUtilization is the module's free function over the same lowering as the method. Adds corpus programs for the typed and JavaScript reads, the key orders, toJSON, stringify, inspection, the frozen list and its write errors, and the module's exports; the perf_hooks rows move from not-implemented to partial, supportedEntryTypes to supported, and the docs limitations list the startup milestones a compiled program cannot measure.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performance.nodeTimingnow answersPerformanceNodeTiming's fields in Node's key order,toJSON(), stringify and inspection, with the live loop metrics and the startup milestones at 0;performance.toJSON(),supportedEntryTypes(one frozen list with Node's write errors) and the module's freeeventLoopUtilizationlower too, typed and through the dynamic tier.perf_hooksrows move offnot-implemented(13 topartial,supportedEntryTypestosupported), with test evidence, andperformance.eventLoopUtilizationgains a third program.