Repository navigation
Conversation
…-namespace loaders, and a `scriptc` export condition
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+2438
to
+2446
| // A `void`-typed operand (ADMITTED `if (fn())` / `!fn()` in an unchecked | ||
| // JavaScript source, tsc-codes.ts TS1345): the lowering produced no value, | ||
| // so Node's ToBoolean is of `undefined` — false — and the operand still | ||
| // runs once for its effects and any exception. Typed sources never reach | ||
| // this: the checker's TS1345 stops them at preflight. | ||
| if (e.type.kind === "void") { | ||
| return { | ||
| kind: "seqExpr", | ||
| stmts: [{ kind: "exprStmt", expr: e, loc: e.loc }], |
Contributor
There was a problem hiding this comment.
A mutable callback alias retains its original function’s signature declaration, so replacing it with a truthy-returning callback still bypasses the guard and compiles its condition to false.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReferenceError(sotypeofguards work), a subclass static whose signature differs from its base's compiles, and a truthiness test of avoid-typed operand reads the value the call returned; a// @ts-checkfile keeps all three diagnostics.() => import("./chunk.mjs")loaders compile and the chunk loads at run time.scriptcexport condition beforenode,import,requireanddefault, with atypesbranch still leading, in every world scriptc resolves (including the type-checked program), and the dependencies page documents it.