Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+76
to
+77
| if (field.type.kind === "func") continue; | ||
| if (field.name === "toJSON") return false; |
Contributor
There was a problem hiding this comment.
A function-valued toJSON field is skipped before the hook check, so eligible instances serialize their fields instead of invoking toJSON.
Comment on lines
+93
to
+101
| function ownOrderMatchesLayout(info: ClassInfo): boolean { | ||
| const declared = info.def.fields.slice(info.base?.def.fields.length ?? 0); | ||
| const own = declared.map((field) => field.name).filter(isClassOwnEnumerableFieldName); | ||
| const created = info.fieldOrder | ||
| .filter((field) => field.redeclared !== true) | ||
| .map((field) => field.name) | ||
| .filter(isClassOwnEnumerableFieldName); | ||
| return own.length === created.length && own.every((name, index) => name === created[index]); | ||
| } |
Contributor
There was a problem hiding this comment.
Classes with array-index field names pass the layout-order check but emit JSON keys in declaration order instead of JavaScript's numeric-key order.
Comment on lines
+179
to
+185
| buf: string, | ||
| obj: string, | ||
| className: string, | ||
| ): void { | ||
| const conv = host.dyn.toDynHelper({ kind: "object", className }); | ||
| const box = B.tmp(); | ||
| B.line(`${box} = call ptr @${conv}(ptr ${obj}) ; +1`); |
Contributor
There was a problem hiding this comment.
When an untyped reference adds toJSON to an otherwise eligible instance, the property-bag fallback serializes its fields without invoking the hook.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toJSONor subclass instance that could reach the value.