Repository navigation
Conversation
getDefaultHighWaterMark/setDefaultHighWaterMark hold per-isolate byte-mode and object-mode defaults that every constructor resolves at construction time, with the setter's integer and range validation. stream.duplexPair builds Node's connected DuplexSide pair, and readable.wrap answers for an old-style source with the push-over-the- high-water-mark pause and the error/close/destroy paths. The typed and checked-dynamic lowerings, ambient declarations, compatibility rows, and docs limitations text follow. Callback slots in the stream state now unlink before releasing what they held. A closure's teardown can run the cycle collector, and a pass that found the released closure still linked would walk an edge whose reference was just given up, leaving a denominator the trial decrement cannot balance and pinning the cycle.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+96
to
+99
| void scr_stream_set_default_hwm(bool object_mode, double value) { | ||
| if (!scr_stream_check_default_hwm(value)) return; | ||
| if (object_mode) scr_stream_default_hwm_object = value; | ||
| else scr_stream_default_hwm_bytes = value; |
Contributor
There was a problem hiding this comment.
After setDefaultHighWaterMark(true, value), Duplex.from(asyncFunction) still uses a high-water mark of 16, ignoring the new object-mode default.
Comment on lines
+4499
to
+4506
| const literal = constArrayLiteral(lowerer, node); | ||
| if (literal !== null) { | ||
| // A spread element's stages are only known at run time. | ||
| const elements = literal.elements.nodes; | ||
| if (elements.some((e) => ts.isSpreadElement(e) || ts.isOmittedExpression(e))) | ||
| return { kind: "dynamic", node }; | ||
| return { kind: "list", stages: elements }; | ||
| } |
Contributor
There was a problem hiding this comment.
Passing a const stage array to pipeline still re-reads its initializer references rather than the stored elements, so reassigned stage variables or changed properties pipe different streams.
Comment on lines
+3190
to
+3192
| const encoding = opts.encodingValue ? hidden("%encoding", opts.encodingValue) : null; | ||
| const signal = opts.signal ? hidden("%signal", opts.signal) : null; | ||
| let out: IrExpr = built; |
Contributor
There was a problem hiding this comment.
Readable.from still reads runtime encoding and signal options before evaluating a web ReadableStream source argument, so source-side updates to those values are ignored.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get/setDefaultHighWaterMarkin both sections,readable.wrap,stream.duplexPair) and records Node's prosehighWaterMark-after-setEncoding()note as not-applicable.DuplexSidepair, and the old-style-source adapter natively, with five new differential corpus programs covering success, ordering, and error shapes.