Repository navigation
Conversation
WiiM devices answer getMetaInfo with plain-text "Failed" when nothing is loaded. The player already treats that as empty metainfo, but the JSON helper logged a warning on every poll (thousands overnight while idle). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DBuBhcANHioWShtwB1sTxq
ccristal
added a commit
to ccristal/python-linkplay
that referenced
this pull request
Oct 19, 2026
Moved to its own PR (velbus#139), as it is a separate problem. This reverts commit df982f4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DBuBhcANHioWShtwB1sTxq
Author
|
Closing as a duplicate of #129, which makes the same change and also handles empty responses. I've added my reproduction details there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When nothing is loaded, a WiiM answers
getMetaInfowith plain-textFailed. Since #93 the player treats that as empty meta info, butsession_call_api_jsonstill logsUnexpected json for .../getMetaInfo: Expecting value: line 1 column 1 (char 0)as a warning first. With Home Assistant polling every 5 s, a WiiM Pro left idle after its overnight restart logged 2,625 of these warnings between 03:11 and 06:50, stopping as soon as playback started.Change
session_call_api_jsonlogs theFailedanswer at debug level. Any other invalid JSON is still a warning, and the exception raised is unchanged.test_meta_info_failed_handlingnow also checks that no warning is logged; that assertion fails without the fix.Testing
pytest: 290 passed, 1 skipped.🤖 Generated with Claude Code