Skip to content

refactor: extract PatternCard component and use sanitize-html - #822

Merged
mbaldessari merged 1 commit into
validatedpatterns:mainfrom
rh-gvincent:refactor_catalog
Sep 15, 2026
Merged

refactor: extract PatternCard component and use sanitize-html#822
mbaldessari merged 1 commit into
validatedpatterns:mainfrom
rh-gvincent:refactor_catalog

Conversation

@rh-gvincent

@rh-gvincent rh-gvincent commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Extract PatternCard into its own component with popover-based requirements table
  • Extract tier label rendering into PatternTierLabel component
  • Add useLocalStorage hook and use it to persist tier filters
  • Replace regex-based sanitizeHTML with sanitize-html library
  • Add sanitize-html and @types/sanitize-html dependencies

@rh-gvincent
rh-gvincent marked this pull request as draft September 11, 2026 12:11
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Hi @rh-gvincent. Thanks for your PR.

I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from darkdoc and mhjacks September 11, 2026 12:11
@rh-gvincent
rh-gvincent force-pushed the refactor_catalog branch 3 times, most recently from 688cd8b to c2b26b3 Compare September 11, 2026 15:14
@rh-gvincent
rh-gvincent marked this pull request as ready for review September 14, 2026 09:35
@openshift-ci
openshift-ci Bot requested a review from day0hero September 14, 2026 09:36
@rh-gvincent
rh-gvincent marked this pull request as draft September 14, 2026 10:44
@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

FWIW I tested this and deployed a pattern via the UI and everything worked okay

@rh-gvincent
rh-gvincent marked this pull request as ready for review September 14, 2026 11:40
@openshift-ci
openshift-ci Bot requested a review from mbaldessari September 14, 2026 11:40
@rh-gvincent
refactor: extract PatternCard component and use sanitize-html
a946ead 
- Extract PatternCard into its own component with popover-based requirements table
- Extract tier label rendering into PatternTierLabel component
- Add useLocalStorage hook and use it to persist tier filters
- Replace regex-based sanitizeHTML with sanitize-html library
- Add sanitize-html and @types/sanitize-html dependencies

Signed-off-by: Guillaume Vincent <gvincent@redhat.com>
@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@red-hat-konflux

red-hat-konflux Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaldessari, rh-gvincent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

I tested the latest iteration and I was able to correctly install mcg (and indeed the tier checkboxes bug is fixed as well ;) )

@mbaldessari

mbaldessari commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 14, 2026
@mbaldessari

mbaldessari commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

konflux is on crack. merging this

@mbaldessari
mbaldessari merged commit fdd9009 into validatedpatterns:main Sep 15, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darkdoc darkdoc Awaiting requested review from darkdoc
@mhjacks mhjacks Awaiting requested review from mhjacks
@day0hero day0hero Awaiting requested review from day0hero
@mbaldessari mbaldessari Awaiting requested review from mbaldessari

Assignees

@mbaldessari mbaldessari

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rh-gvincent @mbaldessari