Fix array expansion with bash 3.x - #634
Merged
Merged
Conversation
On macosx which has bash 3.x
michele@Micheles-Mac-mini ~ % bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin25)
michele@Micheles-Mac-mini ~ % cat /tmp/t.sh
set -euo pipefail
PKI_HOST_MOUNT_ARGS=()
echo "FOO"
echo "${PKI_HOST_MOUNT_ARGS[@]}"
michele@Micheles-Mac-mini ~ % /tmp/t.sh
FOO
/tmp/t.sh: line 6: PKI_HOST_MOUNT_ARGS[@]: unbound variable
Where as the same just works on bash 4.x/5.x:
bash --version
GNU bash, version 5.3.9(1)-release (x86_64-redhat-linux-gnu)
❯ cat /tmp/t.sh
set -euo pipefail
PKI_HOST_MOUNT_ARGS=()
echo "FOO"
echo "${PKI_HOST_MOUNT_ARGS[@]}"
❯ /tmp/t.sh
FOO
❯
We fix this by using the expression:
${VAR_ARRAY[@]+"${VAR_ARRAY[@]}"}
This works both on bash 3.x and also the newer ones. Tested on linux
with bash 5.x and on Mac OSX with bash 3.x
Contributor
Author
|
Once I soak this for a bit here in MCG I'll push to patternizer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macosx which has bash 3.x
Where as the same just works on bash 4.x/5.x:
We fix this by using the expression:
This works both on bash 3.x and also the newer ones. Tested on linux
with bash 5.x and on Mac OSX with bash 3.x