fix(render): render coronas and shadows for offscreen vehicles in drawingEvent - #356
Open
CanerKaraca23 wants to merge 1 commit into
Open
CanerKaraca23 wants to merge 1 commit into
CanerKaraca23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vehicle headlight/taillight ground shadows and light coronas instantly vanishing and popping in when looking away from a vehicle or when the vehicle hull is off-screen.
Details
ModelInfoMgr::OnRenderwas triggered solely insideMEEvents::vehRenderEvent.before(hooked intoCVehicle::Render). When the vehicle's model bounding box leaves the camera frustum / viewport (GetIsOnScreen() == false), the game skips callingCVehicle::Render, causing projected ground shadows and light effects to instantly pop out of existence even when their ground area or light cones are clearly visible to the camera.Events::drawingEventto iterate through active vehicles within reasonable camera distance (!pVeh->GetIsOnScreen()) and renders their light coronas and ground shadows.