Skip to content

fix(clock): prevent DestroyNodeHierarchyRecursive from destroying sibling digit frames - #353

Open
CanerKaraca23 wants to merge 1 commit into
user-grinch:mainfrom
CanerKaraca23:fix/clock-destroy-hierarchy
Open

CanerKaraca23 wants to merge 1 commit into
user-grinch:mainfrom
CanerKaraca23:fix/clock-destroy-hierarchy

Conversation

@CanerKaraca23

Copy link
Copy Markdown
Collaborator

Summary

Fixes an issue where FrameUtil::DestroyNodeHierarchyRecursive destroyed sibling RwFrame nodes in addition to its children by traversing frame->next.

Details

  • Previously, DestroyNodeHierarchyRecursive read frame->next and recursively destroyed it. When called on a child node (such as digit sub-frames during digital clock initialization), this recursively destroyed all following sibling frames belonging to the parent node.
  • Iterates only over the frame's children (frame->child and each child's siblings) to cleanly tear down the descendant hierarchy without touching the target node's siblings.
  • Added null-check for atomic->clump prior to RpClumpRemoveAtomic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant