fix(package): include CRC shared libraries in builds - #180
Open
motphys-developers wants to merge 1 commit into
Open
fix(package): include CRC shared libraries in builds#180motphys-developers wants to merge 1 commit into
motphys-developers wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The build/install artifact does not include
unitree_sdk2py/utils/lib/*.so, which can cause CRC-related functionality to fail after installation because the shared libraries are missing.Changes
MANIFEST.into includeunitree_sdk2py/utils/lib/*.soin the source distributionpackage_datainsetup.pyso the wheel also contains these shared librariesImpact
This only affects packaging output. No runtime business logic was changed.
Verification
.sofiles are present underunitree_sdk2py/utils/lib/