Add ion temp class - #4598
Merged
Merged
Add ion temp class#4598
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4598 +/- ##
==========================================
+ Coverage 49.88% 49.91% +0.03%
==========================================
Files 151 151
Lines 30071 30081 +10
==========================================
+ Hits 15000 15015 +15
+ Misses 15071 15066 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
force-pushed
the
add_ion_temp_class
branch
from
September 15, 2026 16:01
ed95d7d to
22f233a
Compare
chris-ashe
force-pushed
the
add_ion_temp_class
branch
2 times, most recently
from
September 28, 2026 12:14
7b94ff1 to
fb974f0
Compare
chris-ashe
marked this pull request as ready for review
September 28, 2026 12:39
chris-ashe
force-pushed
the
add_ion_temp_class
branch
3 times, most recently
from
September 29, 2026 09:27
8de2f83 to
60e47b9
Compare
… scaled from electron temperature profiles
…ization parameters
…atureProfile in BootstrapCurrent and PlasmaProfile classes
…_pedestal_electron_kev` across various files including documentation, input files, and code logic.
…lasma_separatrix_electron_kev` across multiple files, including documentation, input files, and code logic.
- Introduced `temp_plasma_pedestal_ion_kev` and `temp_plasma_separatrix_ion_kev` to store ion temperature values. - Updated `plot_t_profiles` function to include ion temperature in the output. - Enhanced `Physics` class to output ion temperature values for pedestal and separatrix. - Modified `PlasmaProfile` class to reset ion temperature values appropriately.
chris-ashe
force-pushed
the
add_ion_temp_class
branch
from
September 29, 2026 10:45
60e47b9 to
d8f36c9
Compare
Comment on lines
+650
to
+651
| self.data.physics.temp_plasma_ion_vol_avg_kev | ||
| / self.data.physics.temp_plasma_electron_vol_avg_kev |
Collaborator
There was a problem hiding this comment.
Is this self.data.physics.f_temp_plasma_ion_electron?
Member
Author
There was a problem hiding this comment.
Good spot, yes that should just be self.data.physics.f_temp_plasma_ion_electron. It will give the same value but now makes all the calcs consistent
timothy-nunn
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new explicit class for the ion temperature profile
IonTemperatureProfile. This moves all existing ion temperature function and calculations into the class. This also created a new ion temperature profile array as part ofPlasmaProfilethat can be called for function use instead of having to always multiply the electron profile by the scaling constant. New explicitly variables for the ion and electron temperatures at the pedestals and separatrix's have also been made.Variable Renaming and Standardization:
Renamed all instances of
temp_plasma_pedestal_kevandtemp_plasma_separatrix_kevtotemp_plasma_pedestal_electron_kevandtemp_plasma_separatrix_electron_kevin code, input handling, validation, and plotting routines for improved clarity and consistency.Updated variable mapping for obsolete and legacy variable names to point to the new standardized names.
Documentation and Input File Updates:
Updated documentation and input parameter tables to use the new variable names, and clarified the distinction between electron and ion temperature profiles.
Modified all relevant example input files to use the new variable names.
Plotting and Output Enhancements:
Checklist
I confirm that I have completed the following checks: