You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🐛 Fixes the draft comment composer covering or detaching from selected text; related to #5127.
🧭 Task plan: docs/plans/2026-09-28-plate-5134-main-comment-selection.md
🟢 High confidence in the scoped placement fix.
Phase
🧪 Tests
🌐 Browser
Reproduced
➖ N/A — browser geometry failure
🔴 On original main, the composer covered the first selected line near the top of a 900×330 viewport and detached from the selection near the bottom.
🟢 Real /blocks/editor-ai proof: top/bottom placement, backward multi-block selection, and scroll-driven flip kept the marked range clear with no console/request/page errors.
✅ Outcome Draft comments stay next to the full selected range and keep it clear whenever the composer fits on either side. This targets main as requested.
⚠️ Caveat When neither side fits the full selection, standard Radix shift and available-height behavior applies. Browser proof covers Chrome with the real registry components; other engines and physical devices were not tested. CI owns generated registry payloads.
🏗️ Design Preserve the focus block before collapsing the selection. Merge the live rectangles of every draft-marked leaf through @platejs/floating; let Radix own flip, shift, offset, and collision policy; use Radix's always update strategy only while drafting so the virtual range follows editor scrolling. Existing discussion and suggestion anchoring is unchanged.
🧪 Verifiedpnpm check, pnpm g:build, pnpm --filter www typecheck, pnpm lint:fix, registry source/changelog validation, focused browser geometry, and structured local review passed. The copied registry item declares @platejs/floating; no published package API changed.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Synced with current next; Base UI and Radix placement checks pass on the pushed commit (6/6 in Chrome).
Broader check blockers are documented in the PR description.
minwookshin
changed the title
Keep selected text visible when the comment composer flips above it
Keep the comment composer clear of selected text
Sep 28, 2026
Updated this against main and verified short, wrapped, and multi-block selections. Local pnpm check and the website typecheck pass; the fork workflows are waiting for maintainer approval.
next has no release lane yet. Feel free to PR against main instead.
Resolved and replayed on be74f847d26d074c081e63fb1ce1be68aa4ac686: PR #5134 targets main; its dedicated task plan exists at this exact head and names only PR #5134. Full local checks and focused browser proof pass.
pnpm check and the goal-plan checker pass; focused website typecheck, registry source/changelog checks, browser geometry, and clean second autoreview pass;
GitHub Sync auto-release checkbox check passes.
Final feedback readback before this receipt: 0 inline threads, 0 review bodies/reviews, 6 top-level comments, 0 unresolved actionable P1+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes the draft comment composer covering or detaching from selected text; related to #5127.
🧭 Task plan: docs/plans/2026-09-28-plate-5134-main-comment-selection.md
🟢 High confidence in the scoped placement fix.
main, the composer covered the first selected line near the top of a 900×330 viewport and detached from the selection near the bottom.pnpm check, website typecheck, registry source/changelog checks, clean structured review/blocks/editor-aiproof: top/bottom placement, backward multi-block selection, and scroll-driven flip kept the marked range clear with no console/request/page errors.✅ Outcome Draft comments stay next to the full selected range and keep it clear whenever the composer fits on either side. This targets
mainas requested.🏗️ Design Preserve the focus block before collapsing the selection. Merge the live rectangles of every draft-marked leaf through
@platejs/floating; let Radix own flip, shift, offset, and collision policy; use Radix'salwaysupdate strategy only while drafting so the virtual range follows editor scrolling. Existing discussion and suggestion anchoring is unchanged.🧪 Verified
pnpm check,pnpm g:build,pnpm --filter www typecheck,pnpm lint:fix, registry source/changelog validation, focused browser geometry, and structured local review passed. The copied registry item declares@platejs/floating; no published package API changed.