Repository navigation
Clamp operator counter decrements at zero - #3
Merged
Merged
Conversation
bound_tickets and total_complexity are unsigned; a drifted counter made decrement() throw SQLSTATE 22003 on ticket close/unbind, which aborted projection and left the closed ticket bound to the operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ticket_allocator_operators.bound_tickets/total_complexityare unsigned. When a counter has drifted below the real number of bound tickets (e.g. an external recount raced with Triage increments),OperatorProjectordecrements it below zero and MySQL throws:The exception aborts the projection:
TicketProjector(weight 5) never runs afterOperatorProjector(weight 0), so theticket.closedevent is stored but the ticket stays alive and bound to the operator, occupying a slot.Change
Operator::decrementToZero()— same flow asModel::decrement()(firesupdating, soReadonlyProjectionprotection is kept; touchesupdated_at; syncs attributes), but issuescol = GREATEST(col, n) - natomically in SQL.GREATEST(col - n, 0)would not help:col - non unsigned zero fails beforeGREATESTis evaluated.OperatorProjector: all decrements inonTicketBound(previous operator),onTicketUnbound,onTicketCloseduse it. Increments untouched.Verified
In the host app against local MySQL, inside a rolled-back transaction: operator with
bound_tickets = 0, close its ticket.QueryException22003, ticket not deleted;0, ticket soft-deleted.