Conversation
Federico2014
approved these changes
Oct 30, 2025
0xbigapple
approved these changes
Oct 30, 2025
Contributor
|
The branch has been out of sync for too long. I suggest creating a new branch and merging the changes into the latest branch. |
Contributor
Author
|
@xxo1shine OK, i will create a new PR. |
Contributor
Author
|
@xxo1shine I have udpdate this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
com.squareup.okio:okio:1.17.6as an implementation dependency to address CVE-2023-3635 in the Aliyun SDK HTTP dependency chain.Why are these changes required?
Aliyun DNS publishing uses Okio through the Tea SDK and OkHttp. Excluding Okio breaks that runtime path, so the dependency needs to be upgraded while preserving SDK functionality.
A
resolutionStrategy.forcerule only affects dependency resolution in the current build. Publishing an explicit dependency makes the patched version available to consumers such as java-tron through the library's dependency metadata.This PR has been tested by:
AlgorithmTest,TreeTest,LinkCacheTest,DnsNodeTest, andAwsRoute53Test.git diff --checkpassed.Follow up
Confirm the resolved Okio version when integrating the updated libp2p release into java-tron.
Extra details
Okio 1.17.6 contains the CVE-2023-3635 fix for the 1.x line and does not introduce a Kotlin dependency. CVE-2020-15250 concerns JUnit and is outside the scope of this Okio update; libp2p declares JUnit 4.13.2 for tests.