-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(webapp): floating Ask Trigger chat window #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kathiekiwi
wants to merge
48
commits into
main
Choose a base branch
from
feat/chat-bottom-default-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
7cefff5
feat(webapp): draggable/resizable window primitive
kathiekiwi c46f8b9
fix(webapp): SSR-safe viewport read and viewport-aware resize clamping
kathiekiwi 8d8b039
feat(webapp): dashboard agent as a floating bottom-right window
kathiekiwi 4b93738
fix(webapp): floating chat window review follow-ups
kathiekiwi 9e36628
fix(webapp): keep the Ask Trigger button visible while chat is open
kathiekiwi b9e9e14
fix(webapp): eliminate the drag/resize gesture-baseline race
kathiekiwi a07500a
test(webapp): jsdom regression test for the pan-gesture ordering fix
kathiekiwi c2044a1
fix(webapp): Ask Trigger button closes the chat when clicked while open
kathiekiwi 6e80fbe
fix(webapp): agent-ui story demos the floating window shell
kathiekiwi e1dab30
fix(webapp): close the storybook floating-chat demo on route change
kathiekiwi 90b4002
feat(webapp): dot-matrix variants of the Investigate/Watch icons for …
kathiekiwi 3e7007a
fix(webapp): rounder dot-matrix icons in the ai-agent Shape library
kathiekiwi 2825e45
fix(webapp): dot-matrix icons drawn on the exact Shape library grid
kathiekiwi 308c7d4
feat(webapp): five more Investigate dot-matrix icon candidates
kathiekiwi 597879d
fix(webapp): replace dot-matrix icon candidates with an interactive e…
kathiekiwi cb9f478
feat(webapp): render the owner's 10 drawn dot-matrix icon bitmaps
kathiekiwi 1b644e7
fix(webapp): Investigate/Watch surfaces use the Ask Trigger glyph; dr…
kathiekiwi aed73d5
fix(webapp): live watch result block uses the chat spinner, not a sta…
kathiekiwi 73d0dde
fix(webapp): revert Investigate/Watch icons to original inside the ch…
kathiekiwi 4474a85
docs(webapp): add server-changes note for the floating chat window
kathiekiwi 1447674
fix(webapp): trim verbose comments; drag/resize gate fixes; kill dupl…
kathiekiwi 8ce45c3
fix(webapp): drag filter opts out by marker, not tag, and lives in th…
kathiekiwi c59cf0e
fix(webapp): classify a drag gesture on whichever pan event lands first
kathiekiwi e705833
fix(webapp): resume a chat's in-flight turn on reopen; final comment …
kathiekiwi 8e411e1
fix(webapp): resume prose-only turns too; behavioral resume test; res…
kathiekiwi 8dea45a
fix(webapp): fullscreen toggle remounted the chat; settle-merge misse…
kathiekiwi 00051e9
fix(webapp): raise dashboard agent chat z-index to 30
kathiekiwi 91dbd9b
feat(webapp): add chat display mode icons
kathiekiwi 23b958f
feat(webapp): chat display mode switcher (floating, right panel, full…
kathiekiwi 78cca26
feat(webapp): move chat context and new-chat button under input; 360p…
kathiekiwi 581c25b
fix(webapp): keep chat mounted across display modes; update mode guar…
kathiekiwi 727f592
fix(webapp): floating chat default height 600px
kathiekiwi 984eac5
fix(webapp): add right margin to new chat button
kathiekiwi a8c28b1
fix(webapp): restore fullscreen chat centering
kathiekiwi 971c108
feat(webapp): compact animated chat mode toggle
kathiekiwi 2d91412
fix(webapp): collapse degenerate resizable tracks so fullscreen fits …
kathiekiwi 07a8480
fix(webapp): fullscreen chat column fills takeover height
kathiekiwi e091137
fix(webapp): clear floating geometry when chat docks
kathiekiwi 5ff2924
docs(webapp): mention chat display modes in release note
kathiekiwi 599ee59
fix(webapp): keep resize handle mounted so mode switches never remoun…
kathiekiwi 7088a1a
fix(webapp): mode toggle escape, aria, external collapse
kathiekiwi fe35c95
fix(webapp): keep draft chat composer in the hero block
kathiekiwi 153c64b
fix(webapp): launcher aria-label reflects open state
kathiekiwi d2e20f5
feat(webapp): drag floating chat to edges to dock right or fullscreen
kathiekiwi c7cc318
fix(webapp): restore floating rect on zoned drop; client coords for d…
kathiekiwi b0df83d
feat(webapp): account preference for the chat open position
kathiekiwi 9789afd
fix(webapp): show chat open mode setting to everyone; test the real c…
kathiekiwi 79a0764
fix(webapp): navigation always collapses fullscreen chat
kathiekiwi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| You can now set your preferred Ask Trigger chat position (floating, right panel, or fullscreen) in your account settings — it's used every time you open the chat. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Ask Trigger now opens as a floating window at the bottom of the page that you can drag anywhere and resize. The Ask Trigger button toggles the chat open and closed. You can also switch to a right-side panel or fullscreen view using a toggle in the chat header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| export function ChatFloatingPanel({ className }: { className?: string }) { | ||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path | ||
| d="M19 5H5C3.89543 5 3 5.89543 3 7V17C3 18.1046 3.89543 19 5 19H19C20.1046 19 21 18.1046 21 17V7C21 5.89543 20.1046 5 19 5Z" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <path | ||
| d="M17 10H15C14.4477 10 14 10.4477 14 11V15C14 15.5523 14.4477 16 15 16H17C17.5523 16 18 15.5523 18 15V11C18 10.4477 17.5523 10 17 10Z" | ||
| fill="currentColor" | ||
| /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| export function ChatFullScreen({ className }: { className?: string }) { | ||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path | ||
| d="M19 5H5C3.89543 5 3 5.89543 3 7V17C3 18.1046 3.89543 19 5 19H19C20.1046 19 21 18.1046 21 17V7C21 5.89543 20.1046 5 19 5Z" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <rect x="5" y="7" width="14" height="10" rx="0.5" fill="currentColor" /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| export function ChatRightPanel({ className }: { className?: string }) { | ||
| return ( | ||
| <svg | ||
| className={className} | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path | ||
| d="M19 5H5C3.89543 5 3 5.89543 3 7V17C3 18.1046 3.89543 19 5 19H19C20.1046 19 21 18.1046 21 17V7C21 5.89543 20.1046 5 19 5Z" | ||
| stroke="currentColor" | ||
| strokeWidth="2" | ||
| strokeLinejoin="round" | ||
| /> | ||
| <rect x="15" y="7" width="4" height="10" rx="0.5" fill="currentColor" /> | ||
| </svg> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Feature has duplicate release notes
One chat-display feature ships as two server-change entries, contrary to the repository’s instruction to add one concise user-facing note.
Was this helpful? React with 👍 or 👎 to provide feedback.