Repository navigation
[metrics] Notify value listeners when deleting definitions - #310
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a populated metric definition clears its value without notifying metric listeners. A mounted
MetricViewkeeps displaying the old number even thoughgetMetricreturnsundefined.Notify specific and wildcard listeners through the existing dispatcher after deletion. Absent, empty and repeated deletions stay quiet. If an IDs listener recreates the metric during deletion, preserve its new value and notification.
How did you test this change?
Full
preCommitalso includes Bun, server/database tests and a production build; those additional checks were not run.Prepared with OpenAI Codex assistance.