Repository navigation
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for tigera failed. Why did it fail? →Built without sensitive environment variables
|
There was a problem hiding this comment.
🟡 Changes recommended
The migration reference tables in all three affected files incorrectly replace the documented initial Pending phase with Not set, which could mislead readers about the normal migration sequence.
3 open issues
What changed in this PR
Adds a Calico Open Source DatastoreMigration resource reference for the next, 3.33, and 3.32 documentation trees, and links migration procedures to the new reference.
Changes:
- Adds field, status, phase, deletion, and example YAML documentation for
DatastoreMigration. - Registers the new reference in resource overviews and Calico sidebars.
- Links migration instructions in the CRD migration and on-premises installation guides to the reference.
| File | Description |
|---|---|
| sidebars-calico.js | Adds the DatastoreMigration resource reference to the next-version sidebar. |
| calico/reference/resources/overview.mdx | Lists DatastoreMigration in the next-version resource overview. |
| calico/reference/resources/datastoremigration.mdx | Adds the next-version DatastoreMigration resource reference and documentation. |
| calico/operations/crd-migration.mdx | Links migration status instructions to the new resource reference. |
| calico/getting-started/kubernetes/self-managed-onprem/onpremises.mdx | Links the migration setup instructions to the new resource reference. |
| calico_versioned_sidebars/version-3.33-sidebars.json | Adds the resource reference to the 3.33 sidebar. |
| calico_versioned_sidebars/version-3.32-sidebars.json | Adds the resource reference to the 3.32 sidebar. |
| calico_versioned_docs/version-3.33/reference/resources/overview.mdx | Lists DatastoreMigration in the 3.33 resource overview. |
| calico_versioned_docs/version-3.33/reference/resources/datastoremigration.mdx | Adds the 3.33 DatastoreMigration resource reference and documentation. |
| calico_versioned_docs/version-3.33/operations/crd-migration.mdx | Links 3.33 migration status instructions to the resource reference. |
| calico_versioned_docs/version-3.33/getting-started/kubernetes/self-managed-onprem/onpremises.mdx | Links the 3.33 migration setup instructions to the resource reference. |
| calico_versioned_docs/version-3.32/reference/resources/overview.mdx | Lists DatastoreMigration in the 3.32 resource overview. |
| calico_versioned_docs/version-3.32/reference/resources/datastoremigration.mdx | Adds the 3.32 DatastoreMigration resource reference and documentation. |
| calico_versioned_docs/version-3.32/operations/crd-migration.mdx | Links 3.32 migration status instructions to the resource reference. |
| calico_versioned_docs/version-3.32/getting-started/kubernetes/self-managed-onprem/onpremises.mdx | Links the 3.32 migration setup instructions to the resource reference. |
Review effort: Lite
|
|
||
| | Phase | What happens | | ||
| | ----- | ------------ | | ||
| | Not set | $[prodname] adds the finalizer `migration.projectcalico.org/v1-crd-cleanup` to the resource and locks the datastore. The message is `Waiting for in-flight datastore writes to drain`. | |
There was a problem hiding this comment.
I'm keeping "Not set" here.
On kind clusters at v3.33.1 and v3.32.4, a migration with no conflicts never shows Pending.
The phase is empty while the controller adds the finalizer and locks the datastore.
Then it goes to Migrating, Converged, and Complete.
A watch showed the same on every run.
In ae3051d I added a sentence that says Pending is an accepted value, but a migration with no conflicts doesn't show it.
The procedure pages still say Pending comes first. That needs a separate fix.
PTAL @caseydavenport, and thanks!
|
|
||
| | Phase | What happens | | ||
| | ----- | ------------ | | ||
| | Not set | $[prodname] adds the finalizer `migration.projectcalico.org/v1-crd-cleanup` to the resource and locks the datastore. The message is `Waiting for in-flight datastore writes to drain`. | |
There was a problem hiding this comment.
I'm keeping "Not set" here.
On kind clusters at v3.33.1 and v3.32.4, a migration with no conflicts never shows Pending.
The phase is empty while the controller adds the finalizer and locks the datastore.
Then it goes to Migrating, Converged, and Complete.
A watch showed the same on every run.
In ae3051d I added a sentence that says Pending is an accepted value, but a migration with no conflicts doesn't show it.
The procedure pages still say Pending comes first. That needs a separate fix.
PTAL @caseydavenport, and thanks!
|
|
||
| | Phase | What happens | | ||
| | ----- | ------------ | | ||
| | Not set | $[prodname] adds the finalizer `migration.projectcalico.org/v1-crd-cleanup` to the resource and locks the datastore. The message is `Waiting for in-flight datastore writes to drain`. | |
There was a problem hiding this comment.
I'm keeping "Not set" here.
On kind clusters at v3.33.1 and v3.32.4, a migration with no conflicts never shows Pending.
The phase is empty while the controller adds the finalizer and locks the datastore.
Then it goes to Migrating, Converged, and Complete.
A watch showed the same on every run.
In ae3051d I added a sentence that says Pending is an accepted value, but a migration with no conflicts doesn't show it.
The procedure pages still say Pending comes first. That needs a separate fix.
PTAL @caseydavenport, and thanks!
ctauchen
left a comment
There was a problem hiding this comment.
Find ways to make it clearer that you don't set the values in this resource.

Adds a reference page for the DatastoreMigration resource to Calico Open Source next, 3.33, and 3.32, and links the migration procedures to it.
Jira: https://tigera.atlassian.net/browse/DOCS-3101
Previews: