Skip to content

SCAL-227566 Add PR check that requires tests for source changes - #744

Open
tushardeepakts wants to merge 6 commits into
mainfrom
SCAL-227566
Open

tushardeepakts wants to merge 6 commits into
mainfrom
SCAL-227566

Conversation

@tushardeepakts

@tushardeepakts tushardeepakts commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

A PR that changes src/ code must also add or update a *.spec file, or the new require-tests job fails. Release PRs and PRs labelled 'skip-test-check' are exempt.

Test PR: #747

image image

A PR that changes src/ code must also add or update a *.spec file, or the
new require-tests job fails. Release PRs and PRs labelled
'skip-test-check' are exempt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tushardeepakts
tushardeepakts requested a review from a team as a code owner November 11, 2026 08:24
@tushardeepakts tushardeepakts self-assigned this Nov 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script check-tests-included.js (along with its unit tests and configuration) to ensure that any changes to source files are accompanied by corresponding test files. The feedback suggests improving the git diff command by adding --diff-filter=d to exclude deleted files and prevent false positives, wrapping the command in a try/catch block to handle potential git errors in shallow checkout environments, and updating the unit tests accordingly.

Comment thread scripts/check-tests-included.js Resolved
Comment thread scripts/check-tests-included.spec.js Resolved
@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@744

commit: 648657b

tushardeepakts and others added 4 commits November 11, 2026 16:05
Deleting a source file should not require a test, and deleting a spec
should not count as tests changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant