Repository navigation
SCAL-227566 Add PR check that requires tests for source changes - #744
Open
tushardeepakts wants to merge 6 commits into
Open
tushardeepakts wants to merge 6 commits into
tushardeepakts wants to merge 6 commits into
Conversation
A PR that changes src/ code must also add or update a *.spec file, or the new require-tests job fails. Release PRs and PRs labelled 'skip-test-check' are exempt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new script check-tests-included.js (along with its unit tests and configuration) to ensure that any changes to source files are accompanied by corresponding test files. The feedback suggests improving the git diff command by adding --diff-filter=d to exclude deleted files and prevent false positives, wrapping the command in a try/catch block to handle potential git errors in shallow checkout environments, and updating the unit tests accordingly.
commit: |
Deleting a source file should not require a test, and deleting a spec should not count as tests changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into SCAL-227566
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR that changes src/ code must also add or update a *.spec file, or the new require-tests job fails. Release PRs and PRs labelled 'skip-test-check' are exempt.
Test PR: #747