Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is a combination of 3 open PRs (#148, #149, #151) + some additions. If you chose to merge this one, other three can be closed.
This PR extends support for relocated CLEO 5 folder added in #151. It can be reviewed via this commit.
Basically what happens is that CLEO rewrites paths like
cleo\demo.initoscripts\cleo\demo.inito match the actual file path when the CLEO folder relocated. Modloader has to do the inverse operation and rewrite it back tocleo\demo.inito match the mod folder's structure. Otherwise, users have to create scripts folder inside each mod folder and move mod's CLEO folder there (modloader\mymod\scripts\cleo\demo.ini), which is not ideal.